basetransform: Don't push out identical caps

This avoids triggering plenty of extra code/methods/overhead downstream when
we can just quickly check whenever we want to set caps whether they are
identical or not

https://bugzilla.gnome.org/show_bug.cgi?id=706600
This commit is contained in:
Edward Hervey 2013-08-22 19:01:32 +02:00
parent aa1890a4b4
commit 307d67f8c0

View file

@ -1298,7 +1298,7 @@ gst_base_transform_setcaps (GstBaseTransform * trans, GstPad * pad,
GstCaps * incaps)
{
GstBaseTransformPrivate *priv = trans->priv;
GstCaps *outcaps;
GstCaps *outcaps, *prevcaps;
gboolean ret = TRUE;
GST_DEBUG_OBJECT (pad, "have new caps %p %" GST_PTR_FORMAT, incaps, incaps);
@ -1321,8 +1321,14 @@ gst_base_transform_setcaps (GstBaseTransform * trans, GstPad * pad,
if (!(ret = gst_base_transform_configure_caps (trans, incaps, outcaps)))
goto failed_configure;
/* let downstream know about our caps */
ret = gst_pad_set_caps (trans->srcpad, outcaps);
prevcaps = gst_pad_get_current_caps (trans->srcpad);
if (!prevcaps || !gst_caps_is_equal (outcaps, prevcaps))
/* let downstream know about our caps */
ret = gst_pad_set_caps (trans->srcpad, outcaps);
if (prevcaps)
gst_caps_unref (prevcaps);
if (ret) {
/* try to get a pool when needed */