mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspsrc: fix memory leak of messages

Browse source 
Free messages correctly.
Fixes #577318
This commit is contained in:
Patrick Radizi 2009-05-13 11:50:22 +02:00 committed by Wim Taymans
parent 047618849a
commit 301fc8a712
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/rtsp/gstrtspsrc.c
View file

@ -2951,6 +2951,7 @@ server_eof:
GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL), GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL),
("The server closed the connection.")); ("The server closed the connection."));
src->connected = FALSE; src->connected = FALSE;
gst_rtsp_message_unset (&message);
return GST_FLOW_UNEXPECTED; return GST_FLOW_UNEXPECTED;
} }
interrupt: interrupt:
@ -3001,6 +3002,7 @@ gst_rtspsrc_loop_udp (GstRTSPSrc * src)
{ {
gboolean restart = FALSE; gboolean restart = FALSE;
GstRTSPResult res; GstRTSPResult res;
GstRTSPMessage message = { 0 };
GST_OBJECT_LOCK (src); GST_OBJECT_LOCK (src);
if (src->loop_cmd == CMD_STOP) if (src->loop_cmd == CMD_STOP)
@ -3010,7 +3012,6 @@ gst_rtspsrc_loop_udp (GstRTSPSrc * src)
GST_OBJECT_UNLOCK (src); GST_OBJECT_UNLOCK (src);
while (TRUE) { while (TRUE) {
GstRTSPMessage message = { 0 };
GTimeVal tv_timeout; GTimeVal tv_timeout;
/* get the next timeout interval */ /* get the next timeout interval */
@ -3161,6 +3162,7 @@ handle_request_failed:
GST_ELEMENT_ERROR (src, RESOURCE, WRITE, (NULL), GST_ELEMENT_ERROR (src, RESOURCE, WRITE, (NULL),
("Could not handle server message. (%s)", str)); ("Could not handle server message. (%s)", str));
g_free (str); g_free (str);
gst_rtsp_message_unset (&message);
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
connect_error: connect_error:
@ -3197,6 +3199,7 @@ server_eof:
GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL), GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL),
("The server closed the connection.")); ("The server closed the connection."));
src->connected = FALSE; src->connected = FALSE;
gst_rtsp_message_unset (&message);
return GST_FLOW_UNEXPECTED; return GST_FLOW_UNEXPECTED;
} }
} }
@ -3647,6 +3650,7 @@ receive_error:
handle_request_failed: handle_request_failed:
{ {
/* ERROR was posted */ /* ERROR was posted */
gst_rtsp_message_unset (response);
return res; return res;
} }
server_eof: server_eof:
@ -3654,6 +3658,7 @@ server_eof:
GST_DEBUG_OBJECT (src, "we got an eof from the server"); GST_DEBUG_OBJECT (src, "we got an eof from the server");
GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL), GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL),
("The server closed the connection.")); ("The server closed the connection."));
gst_rtsp_message_unset (response);
return GST_FLOW_UNEXPECTED; return GST_FLOW_UNEXPECTED;
} }
} }