mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:36:20 +00:00
Code Issues 1 Projects Releases Wiki Activity

Timeline: Add doc and more comments/fixmes

Browse source
This commit is contained in:
Edward Hervey 2010-11-26 18:38:49 +01:00
parent 1da6d7a5dd
commit 2ff3d8ce12
1 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ges/ges-timeline.c
View file

@ -29,6 +29,11 @@
* *
* The output type is determined by the #GESTrack that are set on * The output type is determined by the #GESTrack that are set on
* the #GESTimeline. * the #GESTimeline.
*
* To save/load a timeline, you can use the ges_timeline_load_from_uri() and
* ges_timeline_save_to_uri() methods to use the default format. If you wish
* to specify the format to save/load the timeline from, please consult the
* documentation about #GESFormatter.
*/ */
#include "gesmarshal.h" #include "gesmarshal.h"
@ -237,6 +242,10 @@ ges_timeline_new_from_uri (gchar * uri)
{ {
GESTimeline *ret; GESTimeline *ret;
/* FIXME : we should have a GError** argument so the user can know why
* it wasn't able to load the uri
*/
ret = ges_timeline_new (); ret = ges_timeline_new ();
if (!ges_timeline_load_from_uri (ret, uri)) { if (!ges_timeline_load_from_uri (ret, uri)) {
@ -265,6 +274,10 @@ ges_timeline_load_from_uri (GESTimeline * timeline, gchar * uri)
GESFormatter *p = NULL; GESFormatter *p = NULL;
gboolean ret = FALSE; gboolean ret = FALSE;
/* FIXME : we should have a GError** argument so the user can know why
* it wasn't able to load the uri
*/
if (!(p = ges_formatter_new_for_uri (uri))) { if (!(p = ges_formatter_new_for_uri (uri))) {
GST_ERROR ("unsupported uri '%s'", uri); GST_ERROR ("unsupported uri '%s'", uri);
goto fail; goto fail;
@ -300,6 +313,17 @@ ges_timeline_save_to_uri (GESTimeline * timeline, gchar * uri)
GESFormatter *p = NULL; GESFormatter *p = NULL;
gboolean ret = FALSE; gboolean ret = FALSE;
/* FIXME : How will the user be able to chose the format he
* wishes to store to ? */
/* FIXME : How will we ensure a timeline loaded with a certain format
* will be saved with the same one by default ? We need to make this
* easy from an API perspective */
/* FIXME : we should have a GError** argument so the user can know why
* it wasn't able to save
*/
if (!(p = ges_formatter_new_for_uri (uri))) { if (!(p = ges_formatter_new_for_uri (uri))) {
GST_ERROR ("unsupported uri '%s'", uri); GST_ERROR ("unsupported uri '%s'", uri);
goto fail; goto fail;