mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-23 07:38:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: matroskamux avoid -Wmaybe-uninitialized

Browse source 
False positive for the three variables but some warnings like:

   ../tests/check/elements/matroskamux.c:875:10:
    warning: 'chapters_offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
   *index = chapters_offset;
   ~~~~~~~^~~~~~~~~~~~~~~~~

The above is false positive as there is a gboolean to check if it was
initialized or not (found_chapters_declaration).
This commit is contained in:
Victor Toso 2019-01-17 16:19:40 +01:00 committed by Nicolas Dufresne
parent f5bb377a78
commit 2f77d877c3
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/check/elements/matroskamux.c
View file

@ -753,7 +753,8 @@ check_tags (GstToc * ref_toc, GstToc * internal_toc,
{ {
gboolean found_tags = FALSE, must_check_tag = FALSE; gboolean found_tags = FALSE, must_check_tag = FALSE;
guint64 len, value, uid; guint64 len, value, uid;
gsize last_offset, next_tag; gsize last_offset = 0;
gsize next_tag;
gchar *tag_name_str, *tag_string_str; gchar *tag_name_str, *tag_string_str;
guint8 tags[] = { 0x12, 0x54, 0xc3, 0x67 }; guint8 tags[] = { 0x12, 0x54, 0xc3, 0x67 };
guint8 tag[] = { 0x73, 0x73 }; guint8 tag[] = { 0x73, 0x73 };
@ -843,7 +844,9 @@ check_segment (GstToc * ref_toc, GstToc * internal_toc,
guint8 matroska_seek_pos[] = { 0x53, 0xac }; guint8 matroska_seek_pos[] = { 0x53, 0xac };
guint8 matroska_chapters[] = { 0x10, 0x43, 0xA7, 0x70 }; guint8 matroska_chapters[] = { 0x10, 0x43, 0xA7, 0x70 };
guint64 len, value, segment_offset, chapters_offset, tags_offset; guint64 len, value, segment_offset;
guint64 tags_offset = 0;
guint64 chapters_offset = 0;
gboolean found_chapters_declaration = FALSE, found_tags_declaration = FALSE; gboolean found_chapters_declaration = FALSE, found_tags_declaration = FALSE;
/* Segment */ /* Segment */