mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

appsrc: Release priv->lock before pushing segment

Browse source 
Don't hold the private appsrc lock while pushing out a segment
event, which may block indefinitely.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4951>
This commit is contained in:
Jan Schmidt 2023-07-01 00:41:13 +10:00 committed by GStreamer Marge Bot
parent 0461103965
commit 2e5908d33f
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
subprojects/gst-plugins-base/gst-libs/gst/app/gstappsrc.c
View file

@ -1585,6 +1585,7 @@ needs_segment (GstMiniObject * obj)
return TRUE; return TRUE;
} }
/* Called holding the priv->lock, and releases it temporarily */
static void static void
ensure_segment (GstAppSrc * appsrc) ensure_segment (GstAppSrc * appsrc)
{ {
@ -1595,8 +1596,10 @@ ensure_segment (GstAppSrc * appsrc)
GST_EVENT_SEGMENT, 0); GST_EVENT_SEGMENT, 0);
if (!seg_event) { if (!seg_event) {
g_mutex_unlock (&priv->mutex);
GST_DEBUG_OBJECT (appsrc, "sending default segment"); GST_DEBUG_OBJECT (appsrc, "sending default segment");
gst_base_src_push_segment (GST_BASE_SRC_CAST (appsrc), &priv->last_segment); gst_base_src_push_segment (GST_BASE_SRC_CAST (appsrc), &priv->last_segment);
g_mutex_lock (&priv->mutex);
} else { } else {
gst_event_unref (seg_event); gst_event_unref (seg_event);
} }