mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-11 18:05:37 +00:00
Code Issues 1 Projects Releases Wiki Activity

v4l2codecs: decoder: Properly remove pending requests

Browse source 
Pass the pointer instead of NULL in order to find and remove properly any
pending request from the queue. This coding error was leading to use after
free in error and early exit cases.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1696>
This commit is contained in:
Nicolas Dufresne 2020-10-15 11:35:04 -04:00
parent 4af33eda76
commit 2e3bc60422
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/v4l2codecs/gstv4l2decoder.c
View file

@ -854,7 +854,7 @@ gst_v4l2_request_free (GstV4l2Request * request)
GST_DEBUG_OBJECT (decoder, "Freeing pending request %p.", request); GST_DEBUG_OBJECT (decoder, "Freeing pending request %p.", request);
idx = gst_queue_array_find (decoder->pending_requests, NULL, NULL); idx = gst_queue_array_find (decoder->pending_requests, NULL, request);
if (idx >= 0) if (idx >= 0)
gst_queue_array_drop_element (decoder->pending_requests, idx); gst_queue_array_drop_element (decoder->pending_requests, idx);