mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-28 04:31:06 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridecodebin: Don't leak pad references

Browse source
This commit is contained in:
Sebastian Dröge 2014-02-12 17:34:32 +01:00
parent 09644d0e4a
commit 2ddc07e93e
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/playback/gsturidecodebin.c
View file

@ -1506,12 +1506,13 @@ analyse_source (GstURIDecodeBin * decoder, gboolean * is_raw,
gst_iterator_resync (pads_iter);
break;
case GST_ITERATOR_OK:
pad = g_value_get_object (&item);
pad = g_value_dup_object (&item);
/* we now officially have an ouput pad */
*have_out = TRUE;
/* if FALSE, this pad has no caps and we continue with the next pad. */
if (!has_all_raw_caps (pad, rawcaps, is_raw)) {
gst_object_unref (pad);
g_value_reset (&item);
break;
}
@ -1538,12 +1539,14 @@ analyse_source (GstURIDecodeBin * decoder, gboolean * is_raw,
decoder->queue = outelem;
/* get the new raw srcpad */
gst_object_unref (pad);
pad = gst_element_get_static_pad (outelem, "src");
} else {
outelem = decoder->source;
}
expose_decoded_pad (outelem, pad, decoder);
}
gst_object_unref (pad);
g_value_reset (&item);
break;
}
@ -1579,6 +1582,7 @@ no_queue2:
{
post_missing_plugin_error (GST_ELEMENT_CAST (decoder), "queue2");
gst_object_unref (pad);
g_value_unset (&item);
gst_iterator_free (pads_iter);
gst_caps_unref (rawcaps);