mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-10-21 09:53:47 +00:00
ext/wavpack/gstwavpackenc.c: Fix mem leak, send newsegment event on correction pad as well (#352476).
Original commit message from CVS: * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block): Fix mem leak, send newsegment event on correction pad as well (#352476). * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init): Restore original author (on Sebastian's request). * tests/check/Makefile.am: * tests/check/gst-plugins-bad.supp: Add (so far empty) suppression file for -bad. Remove wavpackenc test from VALGRIND_TO_FIX now that the leak is fixed.
This commit is contained in:
parent
4bd2320e4c
commit
2d7cf5f385
6 changed files with 22 additions and 8 deletions
15
ChangeLog
15
ChangeLog
|
@ -1,3 +1,18 @@
|
||||||
|
2006-08-23 Tim-Philipp Müller <tim at centricular dot net>
|
||||||
|
|
||||||
|
* ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_push_block):
|
||||||
|
Fix mem leak, send newsegment event on correction pad
|
||||||
|
as well (#352476).
|
||||||
|
|
||||||
|
* ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init):
|
||||||
|
Restore original author (on Sebastian's request).
|
||||||
|
|
||||||
|
* tests/check/Makefile.am:
|
||||||
|
* tests/check/gst-plugins-bad.supp:
|
||||||
|
Add (so far empty) suppression file for -bad. Remove
|
||||||
|
wavpackenc test from VALGRIND_TO_FIX now that the leak
|
||||||
|
is fixed.
|
||||||
|
|
||||||
2006-08-23 Tim-Philipp Müller <tim at centricular dot net>
|
2006-08-23 Tim-Philipp Müller <tim at centricular dot net>
|
||||||
|
|
||||||
Patch by: Sebastian Dröge <slomo at circular-chaos.org>
|
Patch by: Sebastian Dröge <slomo at circular-chaos.org>
|
||||||
|
|
2
common
2
common
|
@ -1 +1 @@
|
||||||
Subproject commit e9ea99f6e89d7e1af3a0a859bfeb0ed6ecf2e3a9
|
Subproject commit d287125f93da692bc25d53b0b7b0e2f90424a212
|
|
@ -562,13 +562,13 @@ gst_wavpack_enc_push_block (void *id, void *data, int32_t count)
|
||||||
|
|
||||||
/* if it's the first wavpack block, send a NEW_SEGMENT event */
|
/* if it's the first wavpack block, send a NEW_SEGMENT event */
|
||||||
if (wph.block_index == 0) {
|
if (wph.block_index == 0) {
|
||||||
GstEvent *event = gst_event_new_new_segment (FALSE,
|
gst_pad_push_event (pad,
|
||||||
1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0);
|
gst_event_new_new_segment (FALSE,
|
||||||
|
1.0, GST_FORMAT_BYTES, 0, GST_BUFFER_OFFSET_NONE, 0));
|
||||||
|
|
||||||
/* save header for later reference, so we can re-send it later on
|
/* save header for later reference, so we can re-send it later on
|
||||||
* EOS with fixed up values for total sample count etc. */
|
* EOS with fixed up values for total sample count etc. */
|
||||||
if (enc->first_block == NULL && !wid->correction) {
|
if (enc->first_block == NULL && !wid->correction) {
|
||||||
gst_pad_push_event (enc->srcpad, event);
|
|
||||||
enc->first_block = g_memdup (block, count);
|
enc->first_block = g_memdup (block, count);
|
||||||
enc->first_block_size = count;
|
enc->first_block_size = count;
|
||||||
}
|
}
|
||||||
|
|
|
@ -97,7 +97,7 @@ gst_wavpack_parse_base_init (gpointer klass)
|
||||||
GST_ELEMENT_DETAILS ("WavePack parser",
|
GST_ELEMENT_DETAILS ("WavePack parser",
|
||||||
"Codec/Demuxer/Audio",
|
"Codec/Demuxer/Audio",
|
||||||
"Parses Wavpack files",
|
"Parses Wavpack files",
|
||||||
"Sebastian Dröge <slomo@circular-chaos.org>");
|
"Arwed v. Merkatz <v.merkatz@gmx.net>");
|
||||||
GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
|
GstElementClass *element_class = GST_ELEMENT_CLASS (klass);
|
||||||
|
|
||||||
gst_element_class_add_pad_template (element_class,
|
gst_element_class_add_pad_template (element_class,
|
||||||
|
|
|
@ -22,7 +22,7 @@ install-pluginLTLIBRARIES:
|
||||||
# the core dumps of some machines have PIDs appended
|
# the core dumps of some machines have PIDs appended
|
||||||
CLEANFILES = core.* test-registry.xml
|
CLEANFILES = core.* test-registry.xml
|
||||||
|
|
||||||
SUPPRESSIONS = $(top_srcdir)/common/gst.supp
|
SUPPRESSIONS = $(top_srcdir)/common/gst.supp $(srcdir)/gst-plugins-bad.supp
|
||||||
|
|
||||||
clean-local: clean-local-check
|
clean-local: clean-local-check
|
||||||
|
|
||||||
|
@ -42,8 +42,7 @@ check_wavpack =
|
||||||
endif
|
endif
|
||||||
|
|
||||||
VALGRIND_TO_FIX = \
|
VALGRIND_TO_FIX = \
|
||||||
elements/mpeg2enc \
|
elements/mpeg2enc
|
||||||
elements/wavpackenc
|
|
||||||
|
|
||||||
# valgrind testing
|
# valgrind testing
|
||||||
VALGRIND_TESTS_DISABLE = $(VALGRIND_TO_FIX)
|
VALGRIND_TESTS_DISABLE = $(VALGRIND_TO_FIX)
|
||||||
|
|
0
tests/check/gst-plugins-bad.supp
Normal file
0
tests/check/gst-plugins-bad.supp
Normal file
Loading…
Reference in a new issue