mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 17:50:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspsrc: remove useless function calls

Browse source 
Comparing gst_rtspsrc_loop_interleaved and gst_rtspsrc_loop_udp, and investigating on timeout issues, it sounds like a piece of code has been originally copied from udp to the interleaved one. The timeout variable is never used inside the interleaved one. No side effect has been seen in the removed function calls.

The debug message removed is pointless as the timeout used is "src->tcp_timeout" that is fixed.

The presence of the two timeout drove my team in investigating if the reference to the tcp_timeout was correct (it is). Hence we removed the misleading reference to the local timeout variable.
This commit is contained in:
Stefano Buora 2020-02-20 09:06:10 +01:00 committed by GStreamer Merge Bot
parent 1326fcdbcc
commit 2d3dccdba7
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst/rtsp/gstrtspsrc.c
View file

@ -5557,16 +5557,8 @@ gst_rtspsrc_loop_interleaved (GstRTSPSrc * src)
GstRTSPMessage message = { 0 };
GstRTSPResult res;
GstFlowReturn ret = GST_FLOW_OK;
gint64 timeout;
while (TRUE) {
/* get the next timeout interval */
timeout = gst_rtsp_connection_next_timeout_usec (src->conninfo.connection);
GST_DEBUG_OBJECT (src, "doing receive with timeout %" G_GINT64_FORMAT
" seconds, %" G_GINT64_FORMAT " usec", timeout / G_USEC_PER_SEC,
timeout % G_USEC_PER_SEC);
gst_rtsp_message_unset (&message);
/* protect the connection with the connection lock so that we can see when