mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 09:12:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

tag: id3v2: turn redundant check into an assert

Browse source 
We checked this already earlier, so this is dead code.
Leave an assert in place for consistency with the other
branch and in case the rest of the code changes.

CID 1397350.
This commit is contained in:
Tim-Philipp Müller 2016-12-18 12:29:42 +00:00
parent 15123c0455
commit 2cfb446eb9
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst-libs/gst/tag/id3v2.c
View file

@ -243,8 +243,7 @@ gst_tag_list_from_id3v2_tag (GstBuffer * buffer)
goto not_enough_data; /* Invalid frame size */
work.hdr.frame_data_size = read_size - ID3V2_HDR_SIZE - 10;
} else {
if (read_size < ID3V2_HDR_SIZE)
goto not_enough_data; /* Invalid frame size */
g_assert (read_size >= ID3V2_HDR_SIZE); /* checked above */
work.hdr.frame_data_size = read_size - ID3V2_HDR_SIZE;
}