mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-26 14:00:29 +00:00
Code Issues 1 Projects Releases Wiki Activity

glvideomixer: Fixing error with mouse navigation events when no pixel-aspect-ratio

Browse source 
Handling mouse navigation events in glvideomixer element, if no
pixel-aspect-ratio info in the caps, an assertion error is produced
inside gst_util_fraction_multiply because default denominator is zero.

Error fixed:
```
(gst-launch-1.0:102654): GStreamer-CRITICAL **: 00:47:51.598: gst_util_fraction_multiply: assertion 'b_d != 0' failed
```

Simple pipeline to reproduce the issue:
```
gst-launch-1.0 -v glvideomixer name=mix ! glimagesinkelement  gltestsrc  ! mix.sink_0
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3766>
This commit is contained in:
Ruben Gonzalez 2023-01-22 00:52:56 +01:00
parent 4c1d01ff57
commit 2cdfccc3b5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gst-plugins-base/ext/gl/gstglvideomixer.c
View file

@ -1393,7 +1393,7 @@ src_pad_mouse_event (GstElement * element, GstPad * pad, gpointer user_data)
GstGLVideoMixerPad *mix_pad = GST_GL_VIDEO_MIXER_PAD (pad);
GstCaps *caps = gst_pad_get_current_caps (pad);
GstStructure *event_st, *caps_st;
gint par_n, par_d;
gint par_n = 1, par_d = 1;
gdouble event_x, event_y;
GstVideoRectangle rect;