mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-20 21:38:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: y4mreader: fix incompatible cast

Browse source 
Passed pointer in parse_int() are unsigned int (32 bits, unsigned) but
they are dereferenced as a wider long (64 bits, signed). This may lead
to memory corruption.
This commit is contained in:
Víctor Manuel Jáquez Leal 2018-01-10 16:48:07 +01:00
parent ce3593c0f6
commit 2b9712ca2d
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/y4mreader.c
View file

@ -27,7 +27,7 @@
* http://wiki.multimedia.cx/index.php?title=YUV4MPEG2 */
static inline gboolean
parse_int (const gchar * str, glong * out_value_ptr)
parse_int (const gchar * str, guint * out_value_ptr)
{
gint saved_errno;
glong value;
@ -44,7 +44,10 @@ parse_int (const gchar * str, glong * out_value_ptr)
value = strtol (str, NULL, 0);
ret = (errno == 0);
errno = saved_errno;
*out_value_ptr = value;
if (value > 0 && value <= G_MAXUINT)
*out_value_ptr = value;
else
ret = FALSE;
return ret;
}
@ -83,11 +86,11 @@ parse_header (Y4MReader * file)
if ((header[j] != 0x20) && (header[j - 1] == 0x20)) {
switch (header[j]) {
case 'W':
if (!parse_int ((gchar *) & header[j], (glong *) & file->width))
if (!parse_int ((gchar *) & header[j], &file->width))
return FALSE;
break;
case 'H':
if (!parse_int ((gchar *) & header[j], (glong *) & file->height))
if (!parse_int ((gchar *) & header[j], &file->height))
return FALSE;
break;
case 'C':
@ -108,11 +111,11 @@ parse_header (Y4MReader * file)
{
guint num, den;
if (!parse_int ((gchar *) & header[j], (glong *) & num))
if (!parse_int ((gchar *) & header[j], &num))
return FALSE;
while ((header[j] != ':') && (j < i))
j++;
if (!parse_int ((gchar *) & header[j], (glong *) & den))
if (!parse_int ((gchar *) & header[j], &den))
return FALSE;
if (num <= 0 || den <= 0) {