mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-18 15:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: fix crash and leak in bufferlists unit test

Browse source 
Don't access already-freed iterator, makes check-valgrind work and fixes
crash on PPC; unref buffer we're going to steal to make valgrind happy.
This commit is contained in:
Tim-Philipp Müller 2009-06-21 00:26:33 +01:00
parent c2e980f827
commit 2b4d127ca0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/check/gst/gstbufferlist.c
View file

@ -688,6 +688,7 @@ foreach_func4 (GstBuffer ** buffer, guint group, guint idx, ForeachData * data)
fail_unless (buffer != NULL);
fail_unless (*buffer == data->buf[group][idx]);
gst_buffer_unref (*buffer);
*buffer = NULL;
data->iter++;
@ -720,7 +721,6 @@ GST_START_TEST (test_foreach)
data.buf[1][1] = gst_buffer_new ();
gst_buffer_list_iterator_add (it, data.buf[1][1]);
gst_buffer_list_iterator_free (it);
gst_buffer_list_iterator_add_group (it);
fail_unless (gst_buffer_list_get (list, 0, 0) == data.buf[0][0]);
fail_unless (gst_buffer_list_get (list, 0, 1) == NULL);