mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-18 15:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin: fix the autoplugging of parser elements

Browse source 
If there are two parser elements available for the same media format,
then decodebin is autoplugging an extra capsfilter and parser irrespective
of caps and rank. So restrict the decodebin from autoplugging multiple parser
elements back to back in adjacent positions with in a single DecodeChain
for the same media format.

https://bugzilla.gnome.org/show_bug.cgi?id=738416
This commit is contained in:
Sreerenj Balachandran 2014-10-21 12:58:41 +03:00 committed by Sebastian Dröge
parent 9c58cc7e0f
commit 2b0d392741
1 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
gst/playback/gstdecodebin2.c
View file

@ -2036,6 +2036,7 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
/* take first factory */
factory = g_value_get_object (g_value_array_get_nth (factories, 0));
/* Remove selected factory from the list. */
g_value_array_remove (factories, 0);
@ -2092,6 +2093,9 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
* to have other element classes after each other because a
* parser is the only one that does not change the data. A
* valid example for this would be multiple id3demux in a row.
* Also restrict the autoplugging of multiple parsers for same
* media format with in a chain if they are coming one after
* another in adjacent positions.
*/
is_parser_converter = strstr (gst_element_factory_get_metadata (factory,
GST_ELEMENT_METADATA_KLASS), "Parser") != NULL;
@ -2119,6 +2123,27 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad,
skip = TRUE;
}
CHAIN_MUTEX_UNLOCK (chain);
if (!skip && chain->elements) {
GstElementFactory *chainelemfact;
CHAIN_MUTEX_LOCK (chain);
delem = (GstDecodeElement *) chain->elements->data;
chainelemfact = gst_element_get_factory (delem->element);
if (strstr (gst_element_factory_get_metadata (chainelemfact,
GST_ELEMENT_METADATA_KLASS), "Parser")) {
GST_DEBUG_OBJECT (dbin,
"Skipping factory '%s' because the last connected element"
" '%s' in the chain is exactly similiar",
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE_CAST (factory)),
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE_CAST
(chainelemfact)));
CHAIN_MUTEX_UNLOCK (chain);
continue;
}
CHAIN_MUTEX_UNLOCK (chain);
}
if (skip) {
GST_DEBUG_OBJECT (dbin,
"Skipping factory '%s' because it was already used in this chain",