mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 23:06:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

oggdemux: fix audio glitches with low bitrate vorbis

Browse source 
A low bitrate stream which can pack more than 2 seconds of audio
in a page would cause the stream's position to be updated not
often enough, and would trigger a spurious "jump" via a GAP
event. Instead, we update the stream position after calculating
the new overall segment position.

https://bugzilla.gnome.org/show_bug.cgi?id=764966
This commit is contained in:
Vincent Penquerc'h 2016-04-14 14:02:27 +01:00
parent 27e7ca3389
commit 2ac5bd293b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/ogg/gstoggdemux.c
View file

@ -808,8 +808,6 @@ gst_ogg_demux_chain_peer (GstOggPad * pad, ogg_packet * packet,
pad->discont = FALSE; pad->discont = FALSE;
} }
pad->position = ogg->segment.position;
/* don't push the header packets when we are asked to skip them */ /* don't push the header packets when we are asked to skip them */
if (!packet->b_o_s || push_headers) { if (!packet->b_o_s || push_headers) {
if (pad->last_ret == GST_FLOW_OK) { if (pad->last_ret == GST_FLOW_OK) {
@ -854,6 +852,8 @@ gst_ogg_demux_chain_peer (GstOggPad * pad, ogg_packet * packet,
GST_DEBUG_OBJECT (ogg, "ogg current time %" GST_TIME_FORMAT GST_DEBUG_OBJECT (ogg, "ogg current time %" GST_TIME_FORMAT
" (%" G_GINT64_FORMAT ")", GST_TIME_ARGS (current_time), current_time); " (%" G_GINT64_FORMAT ")", GST_TIME_ARGS (current_time), current_time);
pad->position = ogg->segment.position;
/* check stream eos */ /* check stream eos */
if (!pad->is_eos && !delta_unit && if (!pad->is_eos && !delta_unit &&
((ogg->segment.rate > 0.0 && ((ogg->segment.rate > 0.0 &&