mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 14:56:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: fix bus leak in hls_demux testSeek unit test

Browse source 
We add the signal watch in testSeekPreTestCallback so
remove it in testSeekPostTestCallback and not deep inside
some if clause in some other callback somewhere.
This commit is contained in:
Tim-Philipp Müller 2019-03-06 21:32:50 +00:00
parent 5b68e12d01
commit 2ab238a4d0
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/check/elements/adaptive_demux_common.c
View file

@ -433,7 +433,6 @@ testSeekOnStateChanged (GstBus * bus, GstMessage * msg, gpointer user_data)
TEST_TASK_STATE_WAITING_FOR_TESTSRC_STATE_CHANGE) { TEST_TASK_STATE_WAITING_FOR_TESTSRC_STATE_CHANGE) {
GST_DEBUG ("changing test_task_state"); GST_DEBUG ("changing test_task_state");
testData->test_task_state = TEST_TASK_STATE_EXITING; testData->test_task_state = TEST_TASK_STATE_EXITING;
gst_bus_remove_signal_watch (bus);
g_cond_signal (&testData->test_task_state_cond); g_cond_signal (&testData->test_task_state_cond);
} }
g_mutex_unlock (&testData->test_task_state_lock); g_mutex_unlock (&testData->test_task_state_lock);
@ -464,6 +463,7 @@ static void
testSeekPostTestCallback (GstAdaptiveDemuxTestEngine * engine, testSeekPostTestCallback (GstAdaptiveDemuxTestEngine * engine,
gpointer user_data) gpointer user_data)
{ {
GstBus *bus;
GList *walk; GList *walk;
GstAdaptiveDemuxTestCase *testData = GST_ADAPTIVE_DEMUX_TEST_CASE (user_data); GstAdaptiveDemuxTestCase *testData = GST_ADAPTIVE_DEMUX_TEST_CASE (user_data);
@ -472,6 +472,10 @@ testSeekPostTestCallback (GstAdaptiveDemuxTestEngine * engine,
fail_if (td->segment_verification_needed); fail_if (td->segment_verification_needed);
} }
bus = gst_pipeline_get_bus (GST_PIPELINE (engine->pipeline));
gst_bus_remove_signal_watch (bus);
gst_object_unref (bus);
} }
/* function to check total size of data received by AppSink /* function to check total size of data received by AppSink