mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 03:35:21 +00:00
Code Issues 1 Projects Releases Wiki Activity

nonstreamaudio: Avoid using un-initialized value

Browse source 
We would end up with cur_position not set but proceed being at its
default value of TRUE. Instead, properly set proceed to FALSE

CID #1409855
This commit is contained in:
Edward Hervey 2017-05-26 17:41:39 +02:00 committed by Edward Hervey
parent cf362be9ff
commit 2a193cde84
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gst-libs/gst/audio/gstnonstreamaudiodecoder.c
View file

@ -593,9 +593,11 @@ gst_nonstream_audio_decoder_set_property (GObject * object, guint prop_id,
proceed = FALSE;
GST_WARNING_OBJECT (dec, "switching to new output mode failed");
}
} else
} else {
GST_DEBUG_OBJECT (dec,
"cannot call set_output_mode, since it is NULL");
proceed = FALSE;
}
if (proceed) {
gst_nonstream_audio_decoder_output_new_segment (dec, cur_position);
@ -639,9 +641,11 @@ gst_nonstream_audio_decoder_set_property (GObject * object, guint prop_id,
proceed = FALSE;
GST_WARNING_OBJECT (dec, "switching to new subsong mode failed");
}
} else
} else {
GST_DEBUG_OBJECT (dec,
"cannot call set_subsong_mode, since it is NULL");
proceed = FALSE;
}
if (proceed) {
if (GST_CLOCK_TIME_IS_VALID (cur_position))