mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

audio,video: use gst_segment_is_equal instead of memcmp

Browse source 
memcmp will blindly compare the reserved fields, as well as any
padding the compiler may choose to sprinkle in GstSegment.

Fixes valgrind complaints in unit tests, as well as some found via
https://bugzilla.gnome.org/show_bug.cgi?id=738216
This commit is contained in:
Vincent Penquerc'h 2015-03-19 10:48:15 +00:00
parent 964ea678da
commit 2954813b86
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst-libs/gst/audio/gstaudiodecoder.c
View file

@ -622,7 +622,7 @@ gst_audio_decoder_push_event (GstAudioDecoder * dec, GstEvent * event)
dec->output_segment = seg; dec->output_segment = seg;
dec->priv->in_out_segment_sync = dec->priv->in_out_segment_sync =
(memcmp (&dec->input_segment, &seg, sizeof (seg)) == 0); gst_segment_is_equal (&dec->input_segment, &seg);
GST_AUDIO_DECODER_STREAM_UNLOCK (dec); GST_AUDIO_DECODER_STREAM_UNLOCK (dec);
break; break;
} }
@ -1113,7 +1113,7 @@ apply_pending_events (GstAudioDecoder * dec)
dec->output_segment = seg; dec->output_segment = seg;
dec->priv->in_out_segment_sync = dec->priv->in_out_segment_sync =
(memcmp (&dec->input_segment, &seg, sizeof (seg)) == 0); gst_segment_is_equal (&dec->input_segment, &seg);
GST_AUDIO_DECODER_STREAM_UNLOCK (dec); GST_AUDIO_DECODER_STREAM_UNLOCK (dec);
break; break;
} }

4
gst-libs/gst/video/gstvideodecoder.c
View file

@ -909,7 +909,7 @@ gst_video_decoder_push_event (GstVideoDecoder * decoder, GstEvent * event)
GST_VIDEO_DECODER_STREAM_LOCK (decoder); GST_VIDEO_DECODER_STREAM_LOCK (decoder);
decoder->output_segment = segment; decoder->output_segment = segment;
decoder->priv->in_out_segment_sync = decoder->priv->in_out_segment_sync =
(memcmp (&decoder->input_segment, &segment, sizeof (segment)) == 0); gst_segment_is_equal (&decoder->input_segment, &segment);
decoder->priv->last_timestamp_out = GST_CLOCK_TIME_NONE; decoder->priv->last_timestamp_out = GST_CLOCK_TIME_NONE;
GST_VIDEO_DECODER_STREAM_UNLOCK (decoder); GST_VIDEO_DECODER_STREAM_UNLOCK (decoder);
break; break;
@ -2093,7 +2093,7 @@ gst_video_decoder_flush_parse (GstVideoDecoder * dec, gboolean at_eos)
if (segment.format == GST_FORMAT_TIME) { if (segment.format == GST_FORMAT_TIME) {
dec->output_segment = segment; dec->output_segment = segment;
dec->priv->in_out_segment_sync = dec->priv->in_out_segment_sync =
(memcmp (&dec->input_segment, &segment, sizeof (segment)) == 0); gst_segment_is_equal (&dec->input_segment, &segment);
} }
} }
dec->priv->pending_events = dec->priv->pending_events =