mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

videoutilsprivate: fill more video fields.

Browse source 
__gst_video_element_proxy_caps is called by
__gst_video_element_proxy_getcaps with caps set to the caps
allowed downstream. As we didn't set colorimetry or
chroma-site on the resulting caps, upstream considered it
possible to use whatever values it wanted, leading to
not negotiated errors later on.

As the description for that function is:
"Takes caps and copies its video fields to tmpl_caps",
it seems legitimate to set these fields there.

https://bugzilla.gnome.org/show_bug.cgi?id=786172
This commit is contained in:
Mathieu Duponchelle 2017-08-11 20:53:21 +02:00
parent d375a28a37
commit 28943c4399
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst-libs/gst/video/gstvideoutilsprivate.c
View file

@ -58,6 +58,10 @@ __gst_video_element_proxy_caps (GstElement * element, GstCaps * templ_caps,
gst_structure_set_value (s, "framerate", val);
if ((val = gst_structure_get_value (caps_s, "pixel-aspect-ratio")))
gst_structure_set_value (s, "pixel-aspect-ratio", val);
if ((val = gst_structure_get_value (caps_s, "colorimetry")))
gst_structure_set_value (s, "colorimetry", val);
if ((val = gst_structure_get_value (caps_s, "chroma-site")))
gst_structure_set_value (s, "chroma-site", val);
gst_caps_append_structure_full (tmp, s,
gst_caps_features_copy (features));