mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-26 16:06:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

scaletempo: scaletempo: clip the timestamp or duration of gap event if needed

Browse source 
For some cases, maybe the timestamp of gap event is smaller than
segment start value or larger than segment stop value in playback.
And the timestamp plus duration may exceed segment boundary. Need
check and clip the timestamp or duration before recalculating.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8517>
This commit is contained in:
Elliot Chen 2025-02-19 19:25:52 +09:00 committed by GStreamer Marge Bot
parent 644a005ecb
commit 2548503898
1 changed files with 28 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
subprojects/gst-plugins-good/gst/audiofx/gstscaletempo.c
View file

@ -735,22 +735,41 @@ gst_scaletempo_sink_event (GstBaseTransform * trans, GstEvent * event)
gst_segment_init (&scaletempo->out_segment, GST_FORMAT_UNDEFINED); gst_segment_init (&scaletempo->out_segment, GST_FORMAT_UNDEFINED);
} else if (GST_EVENT_TYPE (event) == GST_EVENT_GAP) { } else if (GST_EVENT_TYPE (event) == GST_EVENT_GAP) {
if (scaletempo->scale != 1.0) { if (scaletempo->scale != 1.0) {
GstClockTime gap_ts, gap_duration; GstClockTime gap_start, gap_duration;
gst_event_parse_gap (event, &gap_ts, &gap_duration); GstClockTime gap_stop = GST_CLOCK_TIME_NONE;
if (scaletempo->reverse) { GstClockTime cstart = GST_CLOCK_TIME_NONE;
gap_ts = scaletempo->in_segment.stop - gap_ts; GstClockTime cstop = GST_CLOCK_TIME_NONE;;
} else {
gap_ts = gap_ts - scaletempo->in_segment.start; gst_event_parse_gap (event, &gap_start, &gap_duration);
}
gap_ts = gap_ts / scaletempo->scale + scaletempo->in_segment.start;
if (GST_CLOCK_TIME_IS_VALID (gap_duration)) { if (GST_CLOCK_TIME_IS_VALID (gap_duration)) {
gap_stop = gap_start + gap_duration;
}
if (G_UNLIKELY (!gst_segment_clip (&scaletempo->in_segment,
GST_FORMAT_TIME, gap_start, gap_stop, &cstart, &cstop))) {
GST_DEBUG ("gap event outside configured segment");
goto done;
}
if (scaletempo->reverse) {
cstart = scaletempo->in_segment.stop - cstart;
} else {
cstart -= scaletempo->in_segment.start;
}
cstart = cstart / scaletempo->scale + scaletempo->in_segment.start;
if (GST_CLOCK_TIME_IS_VALID (gap_duration)) {
/* Clip duration if needed */
if (GST_CLOCK_TIME_IS_VALID (cstart)
&& GST_CLOCK_TIME_IS_VALID (cstop)) {
gap_duration = cstop - cstart;
}
gap_duration = gap_duration / ABS (scaletempo->scale); gap_duration = gap_duration / ABS (scaletempo->scale);
} }
gst_event_unref (event); gst_event_unref (event);
event = gst_event_new_gap (gap_ts, gap_duration); event = gst_event_new_gap (cstart, gap_duration);
} }
} }
done:
return GST_BASE_TRANSFORM_CLASS (parent_class)->sink_event (trans, event); return GST_BASE_TRANSFORM_CLASS (parent_class)->sink_event (trans, event);
} }