mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:36:20 +00:00
Code Issues 1 Projects Releases Wiki Activity

webrtcbin: Warn when offer didn't intersect with transceiver caps

Browse source 
We were silently falling back to creating a recvonly offer if the caps
didn't intersect.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
This commit is contained in:
Nirbheek Chauhan 2022-03-15 17:01:59 +05:30 committed by GStreamer Marge Bot
parent 0007fa38e0
commit 253ee75a72
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
View file

@ -4064,7 +4064,7 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options,
goto rejected; goto rejected;
} }
GST_TRACE_OBJECT (webrtc, "trying to compare %" GST_PTR_FORMAT GST_LOG_OBJECT (webrtc, "trying to compare %" GST_PTR_FORMAT
" and %" GST_PTR_FORMAT, offer_caps, trans_caps); " and %" GST_PTR_FORMAT, offer_caps, trans_caps);
/* FIXME: technically this is a little overreaching as some fields we /* FIXME: technically this is a little overreaching as some fields we
@ -4095,6 +4095,8 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options,
/* if no transceiver, then we only receive that stream and respond with /* if no transceiver, then we only receive that stream and respond with
* the intersection with the transceivers codec preferences caps */ * the intersection with the transceivers codec preferences caps */
answer_dir = GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_RECVONLY; answer_dir = GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_RECVONLY;
GST_WARNING_OBJECT (webrtc, "did not find compatible transceiver for "
"offer caps %" GST_PTR_FORMAT ", will only receive", offer_caps);
} }
if (!rtp_trans) { if (!rtp_trans) {