mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-29 21:21:12 +00:00
Code Issues 1 Projects Releases Wiki Activity

parsebin: Ensure non-time subtitle streams get "parsed"

Browse source 
Since https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6153 ,
subtitle "decoders" (i.e. which decode to raw text) are no longer auto-plugged
by parsebin.

But if a given format does not have a parser at all, we would end up outputting
non-time/non-parsed outputs.

In order to mitigate the issue, until such parsers are available, we check if
the subtitle stream is in TIME format or not (i.e. whether it comes from a
parser or demuxer). If not, we attempt to plug in a subtitle "decoder".

Fixes #3463

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6592>
This commit is contained in:
Edward Hervey 2024-04-10 07:22:36 +02:00
parent 9ec99ac6f2
commit 24c0dc9602
1 changed files with 35 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
subprojects/gst-plugins-base/gst/playback/gstparsebin.c
View file

@ -1765,10 +1765,41 @@ connect_pad (GstParseBin * parsebin, GstElement * src, GstParsePad * parsepad,
{ {
gboolean res = FALSE; gboolean res = FALSE;
GString *error_details = NULL; GString *error_details = NULL;
GstFormat segment_format = GST_FORMAT_TIME;
GstPbUtilsCapsDescriptionFlags caps_flags =
gst_pb_utils_get_caps_description_flags (caps);
g_return_val_if_fail (factories != NULL, FALSE); g_return_val_if_fail (factories != NULL, FALSE);
g_return_val_if_fail (factories->n_values > 0, FALSE); g_return_val_if_fail (factories->n_values > 0, FALSE);
/* For subtitles, which can come from standalone files, we need to ensure we
* output a timed/parsed stream. But not all formats have a parser, so we also
* want to try plugging in subtitle "decoders" like `subparse`.
*
* In order to ensure that, if the caps are subtitles, we query the stream
* format to check if it's in time or not. If it's not in time format, we will
* attempt to plugin in a "decoder" (if present). */
if (caps_flags == GST_PBUTILS_CAPS_DESCRIPTION_FLAG_SUBTITLE) {
GstEvent *segment_event =
gst_pad_get_sticky_event (pad, GST_EVENT_SEGMENT, 0);
const GstSegment *segment = NULL;
segment_format = GST_FORMAT_UNDEFINED;
if (segment_event) {
gst_event_parse_segment (segment_event, &segment);
if (segment)
segment_format = segment->format;
}
if (segment == GST_FORMAT_UNDEFINED) {
GstQuery *segment_query = gst_query_new_segment (GST_FORMAT_TIME);
if (gst_pad_query (pad, segment_query)) {
gst_query_parse_segment (segment_query, NULL, &segment_format, NULL,
NULL);
}
gst_query_unref (segment_query);
}
}
GST_DEBUG_OBJECT (parsebin, GST_DEBUG_OBJECT (parsebin,
"pad %s:%s , chain:%p, %d factories, caps %" GST_PTR_FORMAT, "pad %s:%s , chain:%p, %d factories, caps %" GST_PTR_FORMAT,
GST_DEBUG_PAD_NAME (pad), chain, factories->n_values, caps); GST_DEBUG_PAD_NAME (pad), chain, factories->n_values, caps);
@ -1888,9 +1919,11 @@ connect_pad (GstParseBin * parsebin, GstElement * src, GstParsePad * parsepad,
} }
/* Expose pads if the next factory is a decoder */ /* Expose pads if the next factory is a decoder. segment_format might be not
* time for subtitle streams */
if (gst_element_factory_list_is_type (factory, if (gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_DECODER)) { GST_ELEMENT_FACTORY_TYPE_DECODER)
&& segment_format == GST_FORMAT_TIME) {
ret = GST_AUTOPLUG_SELECT_EXPOSE; ret = GST_AUTOPLUG_SELECT_EXPOSE;
} else { } else {
/* emit autoplug-select to see what we should do with it. */ /* emit autoplug-select to see what we should do with it. */