gst/elements/gstfakesink.c: don't error when we are in error already the correct fix would be to not allow erroring i...

Original commit message from CVS:
* gst/elements/gstfakesink.c: (gst_fakesink_change_state):
don't error when we are in error already
the correct fix would be to not allow erroring in downwards
state changes, but I guess the API police would hunt me down if I
did that
This commit is contained in:
Benjamin Otte 2005-05-01 16:20:42 +00:00
parent 3670c2f9dc
commit 2457c84338
3 changed files with 12 additions and 2 deletions

View file

@ -1,3 +1,11 @@
2005-05-01 Benjamin Otte <in7y118@public.uni-hamburg.de>
* gst/elements/gstfakesink.c: (gst_fakesink_change_state):
don't error when we are in error already
the correct fix would be to not allow erroring in downwards
state changes, but I guess the API police would hunt me down if I
did that
2005-04-26 Wim Taymans <wim@fluendo.com>
* gst/gsttrashstack.h:

View file

@ -396,7 +396,8 @@ gst_fakesink_change_state (GstElement * element)
goto error;
break;
case GST_STATE_PLAYING_TO_PAUSED:
if (fakesink->state_error == FAKESINK_STATE_ERROR_PLAYING_PAUSED)
if (!GST_FLAG_IS_SET (fakesink, GST_ELEMENT_IN_ERROR) &&
fakesink->state_error == FAKESINK_STATE_ERROR_PLAYING_PAUSED)
goto error;
break;
case GST_STATE_PAUSED_TO_READY:

View file

@ -396,7 +396,8 @@ gst_fakesink_change_state (GstElement * element)
goto error;
break;
case GST_STATE_PLAYING_TO_PAUSED:
if (fakesink->state_error == FAKESINK_STATE_ERROR_PLAYING_PAUSED)
if (!GST_FLAG_IS_SET (fakesink, GST_ELEMENT_IN_ERROR) &&
fakesink->state_error == FAKESINK_STATE_ERROR_PLAYING_PAUSED)
goto error;
break;
case GST_STATE_PAUSED_TO_READY: