mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: caps: add raw caps image formats with same chroma of surfaces

Browse source 
Instead of adding a list of ad-hoc formats for raw caps (I420 and
YV12), the display queries the available image formats and we assume
that driver can download frames in that available format with same
chroma of the config surfaces chroma.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>
This commit is contained in:
Víctor Manuel Jáquez Leal 2020-08-01 15:03:22 +02:00 committed by GStreamer Merge Bot
parent 9db747e4d0
commit 2327ac4a13
1 changed files with 41 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
sys/va/gstvacaps.c
View file

@ -93,20 +93,6 @@ bail:
return NULL; return NULL;
} }
static gboolean
_array_has_format (GArray * formats, GstVideoFormat format)
{
GstVideoFormat fmt;
guint i;
for (i = 0; i < formats->len; i++) {
fmt = g_array_index (formats, GstVideoFormat, i);
if (fmt == format)
return TRUE;
}
return FALSE;
}
static gboolean static gboolean
_gst_caps_set_format_array (GstCaps * caps, GArray * formats) _gst_caps_set_format_array (GstCaps * caps, GArray * formats)
{ {
@ -241,21 +227,51 @@ gst_va_create_raw_caps_from_config (GstVaDisplay * display, VAConfigID config)
caps = gst_caps_merge (caps, feature_caps); caps = gst_caps_merge (caps, feature_caps);
} }
/* raw caps */ /* raw caps */
/* XXX(victor): assumption -- drivers can only download to image
* formats with same chroma of surface's format
*/
{ {
feature_caps = GstCaps *raw_caps;
GArray *image_formats = gst_va_display_get_image_formats (display);
if (!image_formats) {
raw_caps = gst_caps_copy (base_caps);
} else {
GArray *raw_formats = g_array_new (FALSE, FALSE, sizeof (GstVideoFormat));
guint j, surface_chroma, image_chroma;
GstVideoFormat image_format;
raw_caps =
gst_caps_new_simple ("video/x-raw", "width", GST_TYPE_INT_RANGE, gst_caps_new_simple ("video/x-raw", "width", GST_TYPE_INT_RANGE,
min_width, max_width, "height", GST_TYPE_INT_RANGE, min_height, min_width, max_width, "height", GST_TYPE_INT_RANGE, min_height,
max_height, NULL); max_height, NULL);
if (_array_has_format (formats, GST_VIDEO_FORMAT_NV12)) { for (i = 0; i < formats->len; i++) {
for (i = 0; i < G_N_ELEMENTS (extra_formats); i++) format = g_array_index (formats, GstVideoFormat, i);
g_array_append_val (formats, extra_formats[i]); surface_chroma = gst_va_chroma_from_video_format (format);
if (surface_chroma == 0)
continue;
g_array_append_val (raw_formats, format);
for (j = 0; j < image_formats->len; j++) {
image_format = g_array_index (image_formats, GstVideoFormat, j);
image_chroma = gst_va_chroma_from_video_format (image_format);
if (image_format != format && surface_chroma == image_chroma)
g_array_append_val (raw_formats, image_format);
}
} }
if (_gst_caps_set_format_array (feature_caps, formats)) if (!_gst_caps_set_format_array (raw_caps, raw_formats)) {
caps = gst_caps_merge (caps, feature_caps); gst_caps_unref (raw_caps);
else raw_caps = gst_caps_copy (base_caps);
gst_clear_caps (&feature_caps); }
g_array_unref (raw_formats);
g_array_unref (image_formats);
}
caps = gst_caps_merge (caps, raw_caps);
} }
gst_caps_unref (base_caps); gst_caps_unref (base_caps);