mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-14 12:04:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: Fix races in the read-growing-file test

Browse source 
First: the buffer is pushed on the encoding filesink only *after* the
checkpoints, leading to wrong ordering in expectations.

The second one is about EOS being posted on the bus *before* the
stop action is executed, leading to the action never being executed.
That action was plain useless as the default behavior of validate
scenario is to internally create a "stop" action on EOS (unless
disabled by user).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/968>
This commit is contained in:
Thibault Saunier 2020-12-09 10:40:40 -03:00
parent f1f966d987
commit 22d37a930c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/validate/giosrc/read-growing-file.validatetest
View file

@ -20,11 +20,13 @@ meta,
crank-clock, repeat=5
wait, on-clock=true
wait, signal-name=waiting-data, target-element-name=giosrc
checkpoint
crank-clock, repeat=5
wait, on-clock=true
wait, signal-name=waiting-data, target-element-name=giosrc
wait, signal-name=done-waiting-data, target-element-name=giosrc, non-blocking=true
@ -36,7 +38,5 @@ wait, signal-name=waiting-data, target-element-name=giosrc
checkpoint
# Make sure EOS is outputted now.
# Make sure EOS is outputted now, the scenario will automatically quit on EOS
set-properties, giosrc::is_growing=false
stop, on-message=eos