mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-08 07:35:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

kmssink: Don't assume buffer pool won't touch buf pointer

Browse source 
Just for extra safety, let's not assume that gst_buffer_pool_acquire()
won't ever touch the buf pointer.
This commit is contained in:
Nicolas Dufresne 2017-09-08 09:28:19 -04:00
parent 7e38fb5422
commit 22ce257f1c
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sys/kms/gstkmssink.c
View file

@ -1187,9 +1187,8 @@ gst_kms_sink_copy_to_dumb_buffer (GstKMSSink * self, GstBuffer * inbuf)
GstFlowReturn ret; GstFlowReturn ret;
GstVideoFrame inframe, outframe; GstVideoFrame inframe, outframe;
gboolean success; gboolean success;
GstBuffer *buf; GstBuffer *buf = NULL;
buf = NULL;
if (!gst_buffer_pool_set_active (self->pool, TRUE)) if (!gst_buffer_pool_set_active (self->pool, TRUE))
goto activate_pool_failed; goto activate_pool_failed;
@ -1223,13 +1222,13 @@ activate_pool_failed:
{ {
GST_ELEMENT_ERROR (self, STREAM, FAILED, ("failed to activate buffer pool"), GST_ELEMENT_ERROR (self, STREAM, FAILED, ("failed to activate buffer pool"),
("failed to activate buffer pool")); ("failed to activate buffer pool"));
goto bail; return NULL;
} }
create_buffer_failed: create_buffer_failed:
{ {
GST_ELEMENT_ERROR (self, STREAM, FAILED, ("allocation failed"), GST_ELEMENT_ERROR (self, STREAM, FAILED, ("allocation failed"),
("failed to create buffer")); ("failed to create buffer"));
goto bail; return NULL;
} }
error_copy_buffer: error_copy_buffer:
{ {