mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-26 16:06:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

videodecoder: Add max-errors property

Browse source 
The number of consecutive decode errors that should be tolerated before
returning flow error should be up to the application, not the element.

Hence max-error should be exposed as a property.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/720>
This commit is contained in:
Haakon Sporsheim 2020-06-22 21:36:02 +03:00 committed by GStreamer Merge Bot
parent 220f2dd3c7
commit 226a371e3f
1 changed files with 26 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
gst-libs/gst/video/gstvideodecoder.c
View file

@ -289,11 +289,13 @@ GST_DEBUG_CATEGORY (videodecoder_debug);
/* properties */ /* properties */
#define DEFAULT_QOS TRUE #define DEFAULT_QOS TRUE
#define DEFAULT_MAX_ERRORS GST_VIDEO_DECODER_MAX_ERRORS
enum enum
{ {
PROP_0, PROP_0,
PROP_QOS, PROP_QOS,
PROP_MAX_ERRORS,
}; };
struct _GstVideoDecoderPrivate struct _GstVideoDecoderPrivate
@ -573,6 +575,20 @@ gst_video_decoder_class_init (GstVideoDecoderClass * klass)
g_param_spec_boolean ("qos", "Quality of Service", g_param_spec_boolean ("qos", "Quality of Service",
"Handle Quality-of-Service events from downstream", "Handle Quality-of-Service events from downstream",
DEFAULT_QOS, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); DEFAULT_QOS, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
/**
* GstVideoDecoder:max-errors:
*
* Maximum number of tolerated consecutive decode errors. See
* gst_video_decoder_set_max_errors() for more details.
*
* Since: 1.18
*/
g_object_class_install_property (gobject_class, PROP_MAX_ERRORS,
g_param_spec_int ("max-errors", "Max errors",
"Max consecutive decoder errors before returning flow error",
-1, G_MAXINT, DEFAULT_MAX_ERRORS,
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
} }
static void static void
@ -831,12 +847,16 @@ static void
gst_video_decoder_get_property (GObject * object, guint property_id, gst_video_decoder_get_property (GObject * object, guint property_id,
GValue * value, GParamSpec * pspec) GValue * value, GParamSpec * pspec)
{ {
GstVideoDecoderPrivate *priv = GST_VIDEO_DECODER (object)->priv; GstVideoDecoder *dec = GST_VIDEO_DECODER (object);
GstVideoDecoderPrivate *priv = dec->priv;
switch (property_id) { switch (property_id) {
case PROP_QOS: case PROP_QOS:
g_value_set_boolean (value, priv->do_qos); g_value_set_boolean (value, priv->do_qos);
break; break;
case PROP_MAX_ERRORS:
g_value_set_int (value, gst_video_decoder_get_max_errors (dec));
break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break; break;
@ -847,12 +867,16 @@ static void
gst_video_decoder_set_property (GObject * object, guint property_id, gst_video_decoder_set_property (GObject * object, guint property_id,
const GValue * value, GParamSpec * pspec) const GValue * value, GParamSpec * pspec)
{ {
GstVideoDecoderPrivate *priv = GST_VIDEO_DECODER (object)->priv; GstVideoDecoder *dec = GST_VIDEO_DECODER (object);
GstVideoDecoderPrivate *priv = dec->priv;
switch (property_id) { switch (property_id) {
case PROP_QOS: case PROP_QOS:
priv->do_qos = g_value_get_boolean (value); priv->do_qos = g_value_get_boolean (value);
break; break;
case PROP_MAX_ERRORS:
gst_video_decoder_set_max_errors (dec, g_value_get_int (value));
break;
default: default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec); G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break; break;