mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-25 19:21:06 +00:00
Code Issues 1 Projects Releases Wiki Activity

cea708overlay: fix HCR interpretation

Browse source 
An unsigned counter with a for (i = end; i >= 0; i--), can be optimized to
infinite loop as an unsigned value will always be >= 0.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4133>
This commit is contained in:
Matthew Waters 2023-03-09 14:38:13 +11:00
parent ad30fb87c2
commit 22229d9546
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subprojects/gst-plugins-bad/ext/closedcaption/gstcea708decoder.c
View file

@ -983,13 +983,13 @@ static void
gst_cea708dec_show_pango_window (Cea708Dec * decoder, guint window_id) gst_cea708dec_show_pango_window (Cea708Dec * decoder, guint window_id)
{ {
cea708Window *window = decoder->cc_windows[window_id]; cea708Window *window = decoder->cc_windows[window_id];
guint16 row, col; gint16 row, col;
gboolean display = FALSE; /* = TRUE when text lines should be written */ gboolean display = FALSE; /* = TRUE when text lines should be written */
gchar line_buffer[LINEBUFFER_SIZE]; gchar line_buffer[LINEBUFFER_SIZE];
gchar outchar_utf8[CC_UTF8_MAX_LENGTH + 1] = { 0 }; gchar outchar_utf8[CC_UTF8_MAX_LENGTH + 1] = { 0 };
guint8 utf8_char_length; guint8 utf8_char_length;
guint16 i, j; gint16 i, j;
guint16 right_index; /* within a single line of window text, the gint16 right_index; /* within a single line of window text, the
* index of the rightmost non-blank character */ * index of the rightmost non-blank character */
guint16 index; guint16 index;
guint len = 0; guint len = 0;
@ -1653,8 +1653,8 @@ static void
gst_cea708dec_window_add_char (Cea708Dec * decoder, gunichar c) gst_cea708dec_window_add_char (Cea708Dec * decoder, gunichar c)
{ {
cea708Window *window = decoder->cc_windows[decoder->current_window]; cea708Window *window = decoder->cc_windows[decoder->current_window];
guint16 pen_row; gint16 pen_row;
guint16 pen_col; gint16 pen_col;
/* Add one character to the current window, using current pen location. /* Add one character to the current window, using current pen location.
* Wrap pen location if necessary */ * Wrap pen location if necessary */