mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: bufferpool: use release_buffer to clean the mem.

Browse source 
The current bufferpool wastes all pre-allocate buffers when the
buffer pool is actived.
The pool->priv->size is 0 for va buffer pool. And every time, the
reset_buffer() will clean all mem and make the buffer size 0, that
can cache the gst_buffer in the buffer pool.
But when the buffer pool is activing, the default_start() just
allocate the buffer and release_buffer() immediately, all the pre
allocated buffers and surfaces are destroyed because of
gst_buffer_get_size (buffer) != pool->priv->size.
We need to use release_buffer() to do the clean job at the pool
start time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1686>
This commit is contained in:
He Junyan 2020-10-13 15:28:24 +08:00
parent 634eb1fc38
commit 21f4c31a52
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
sys/va/gstvapool.c
View file

@ -249,16 +249,26 @@ no_memory:
static void
gst_va_pool_reset_buffer (GstBufferPool * pool, GstBuffer * buffer)
{
GstVaPool *vpool = GST_VA_POOL (pool);
/* Clears all the memories and only pool the GstBuffer objects */
if (G_LIKELY (!vpool->starting))
gst_buffer_remove_all_memory (buffer);
gst_buffer_remove_all_memory (buffer);
GST_BUFFER_POOL_CLASS (parent_class)->reset_buffer (pool, buffer);
if (G_LIKELY (!vpool->starting))
GST_BUFFER_FLAGS (buffer) = 0;
}
static void
gst_va_pool_release_buffer (GstBufferPool * pool, GstBuffer * buffer)
{
GstVaPool *vpool = GST_VA_POOL (pool);
/* Clears all the memories and only pool the GstBuffer objects */
if (G_UNLIKELY (vpool->starting)) {
gst_buffer_remove_all_memory (buffer);
GST_BUFFER_FLAGS (buffer) = 0;
}
GST_BUFFER_POOL_CLASS (parent_class)->release_buffer (pool, buffer);
}
static GstFlowReturn
@ -337,6 +347,7 @@ gst_va_pool_class_init (GstVaPoolClass * klass)
gstbufferpool_class->set_config = gst_va_pool_set_config;
gstbufferpool_class->alloc_buffer = gst_va_pool_alloc;
gstbufferpool_class->reset_buffer = gst_va_pool_reset_buffer;
gstbufferpool_class->release_buffer = gst_va_pool_release_buffer;
gstbufferpool_class->acquire_buffer = gst_va_pool_acquire_buffer;
gstbufferpool_class->flush_start = gst_va_pool_flush_start;
gstbufferpool_class->start = gst_va_pool_start;