mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 05:46:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert fix for regression in #347408 after release.

Browse source 
Original commit message from CVS:
* libs/gst/base/gstbasesrc.c: (gst_base_src_update_length):
* tests/check/elements/filesrc.c: (GST_START_TEST):
Revert fix for regression in #347408 after release.
This commit is contained in:
Wim Taymans 2006-07-14 16:42:20 +00:00
parent 147c3d0ef6
commit 21b8eaeab5
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
2006-07-14 Wim Taymans <wim@fluendo.com>
* libs/gst/base/gstbasesrc.c: (gst_base_src_update_length):
* tests/check/elements/filesrc.c: (GST_START_TEST):
Revert fix for regression in #347408 after release.
2006-07-14 Tim-Philipp Müller <tim at centricular dot net> 2006-07-14 Tim-Philipp Müller <tim at centricular dot net>
Patch by: Antoine Tremblay <hexa00 at gmail com> Patch by: Antoine Tremblay <hexa00 at gmail com>

4
libs/gst/base/gstbasesrc.c
View file

@ -1238,10 +1238,6 @@ gst_base_src_update_length (GstBaseSrc * src, guint64 offset, guint * length)
*length = maxsize - offset; *length = maxsize - offset;
} }
} }
/* FIXME, remove this check after release. Some elements pull 0 bytes
* and expect an UNEXPECTED return value (id3demux) */
if (*length == 0)
goto unexpected_length;
/* keep track of current position. segment is in bytes, we checked /* keep track of current position. segment is in bytes, we checked
* that above. */ * that above. */

2
tests/check/elements/filesrc.c
View file

@ -186,14 +186,12 @@ GST_START_TEST (test_pull)
fail_unless (GST_BUFFER_SIZE (buffer1) == 10); fail_unless (GST_BUFFER_SIZE (buffer1) == 10);
gst_buffer_unref (buffer1); gst_buffer_unref (buffer1);
#if 0 /* enable after 0 bytes pulls are fixed */
/* read 0 bytes at end-1 should return 0 bytes */ /* read 0 bytes at end-1 should return 0 bytes */
ret = gst_pad_get_range (pad, stop - 1, 0, &buffer1); ret = gst_pad_get_range (pad, stop - 1, 0, &buffer1);
fail_unless (ret == GST_FLOW_OK); fail_unless (ret == GST_FLOW_OK);
fail_unless (buffer1 != NULL); fail_unless (buffer1 != NULL);
fail_unless (GST_BUFFER_SIZE (buffer1) == 0); fail_unless (GST_BUFFER_SIZE (buffer1) == 0);
gst_buffer_unref (buffer1); gst_buffer_unref (buffer1);
#endif
/* read 10 bytes at end-1 should return 1 byte */ /* read 10 bytes at end-1 should return 1 byte */
ret = gst_pad_get_range (pad, stop - 1, 10, &buffer1); ret = gst_pad_get_range (pad, stop - 1, 10, &buffer1);