mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-23 00:10:40 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/gstsystemclock.c: Add some more docs to explain why a FIXME was wrongly added.

Browse source 
Original commit message from CVS:
* gst/gstsystemclock.c: (gst_system_clock_id_wait_jitter_unlocked):
Add some more docs to explain why a FIXME was wrongly added.
This commit is contained in:
Wim Taymans 2007-12-24 14:35:24 +00:00
parent 43377772a6
commit 20b951efc1
2 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2007-12-24 Wim Taymans <wim.taymans@collabora.co.uk>
* gst/gstsystemclock.c: (gst_system_clock_id_wait_jitter_unlocked):
Add some more docs to explain why a FIXME was wrongly added.
2007-12-22 Sebastian Dröge <slomo@circular-chaos.org> 2007-12-22 Sebastian Dröge <slomo@circular-chaos.org>
* gst/gstobject.c: * gst/gstobject.c:

14
gst/gstsystemclock.c
View file

@ -363,7 +363,8 @@ gst_system_clock_id_wait_jitter_unlocked (GstClock * clock,
GstClockTime entryt, real, now, target; GstClockTime entryt, real, now, target;
GstClockTimeDiff diff; GstClockTimeDiff diff;
/* need to call the overridden method */ /* need to call the overridden method because we want to sync against the time
* of the clock, whatever the subclass uses as a clock. */
real = GST_CLOCK_GET_CLASS (clock)->get_internal_time (clock); real = GST_CLOCK_GET_CLASS (clock)->get_internal_time (clock);
entryt = GST_CLOCK_ENTRY_TIME (entry); entryt = GST_CLOCK_ENTRY_TIME (entry);
@ -371,12 +372,13 @@ gst_system_clock_id_wait_jitter_unlocked (GstClock * clock,
if (jitter) { if (jitter) {
*jitter = GST_CLOCK_DIFF (entryt, now); *jitter = GST_CLOCK_DIFF (entryt, now);
} }
/* the diff of the entry with the clock is the amount of time we have to
* wait */
diff = entryt - now; diff = entryt - now;
/* FIXME: should that be not just: /* Our GCond implementation expects an absolute time against the system clock
* target = GST_CLOCK_GET_CLASS (clock)->get_internal_time (clock) + diff; * as a timeout value. We use our internal time to get the system time and add
* or even * the expected timeout to it, this gives us the absolute time of the
* target = real + diff; * timeout. */
*/
target = gst_system_clock_get_internal_time (clock) + diff; target = gst_system_clock_get_internal_time (clock) + diff;
GST_CAT_DEBUG (GST_CAT_CLOCK, "entry %p" GST_CAT_DEBUG (GST_CAT_CLOCK, "entry %p"