mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-29 07:12:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

fix faad2 version check

Browse source 
On fedora 22, the output of cpp inserts extra debug comments, which
makes our regexp for the faad2 version check fail. This in turn causes
it to compile with the wrong arguments passed which then causes stack
corruption and crashes.

Fix this by only checking for the version (which should be by itself on
a single line). This is potentially less safe, it might be possible that
a similar string would appear in a later version in the header file.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=748571
This commit is contained in:
Wim Taymans 2015-05-13 16:23:26 +02:00
parent 07dffe9e5b
commit 1f738ca5b8
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
configure.ac
View file

@ -2008,9 +2008,9 @@ AG_GST_CHECK_FEATURE(FAAD, [AAC decoder plug-in], faad, [
AC_MSG_CHECKING([Checking FAAD2 version in $faad_hdr])
for minor in 10 9 8 7 6 5 0; do
if test x$faad2_minor_version = "x"; then
AC_EGREP_CPP([GST_CHECK_FAAD_VERSION \"2\.$minor\"], [
AC_EGREP_CPP([\"2\.$minor\"$], [
#include <$faad_hdr>
GST_CHECK_FAAD_VERSION FAAD2_VERSION
FAAD2_VERSION
], [
faad2_minor_version=$minor
])