mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/dvdlpcmdec/gstdvdlpcmdec.c: Add a small sanity check for LPCM reading.

Browse source 
Original commit message from CVS:
* gst/dvdlpcmdec/gstdvdlpcmdec.c: (gst_dvdlpcmdec_chain_dvd):
Add a small sanity check for LPCM reading.
This commit is contained in:
Jan Schmidt 2006-02-17 10:10:40 +00:00
parent 821effe791
commit 1f14799cea
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2006-02-17 Jan Schmidt <thaytan@mad.scientist.com>
* gst/dvdlpcmdec/gstdvdlpcmdec.c: (gst_dvdlpcmdec_chain_dvd):
Add a small sanity check for LPCM reading.
2006-02-17 Edward Hervey <edward@fluendo.com>
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_process_file):

17
gst/dvdlpcmdec/gstdvdlpcmdec.c
View file

@ -323,6 +323,15 @@ gst_dvdlpcmdec_chain_dvd (GstPad * pad, GstBuffer * buf)
size = GST_BUFFER_SIZE (buf);
data = GST_BUFFER_DATA (buf);
if (size < 5) {
/* Buffer is too small */
GST_ELEMENT_WARNING (dvdlpcmdec, STREAM, DECODE,
("Invalid data found parsing LPCM packet"),
("LPCM packet was too small. Dropping"));
ret = GST_FLOW_OK;
goto done;
}
/* We have a 5 byte header, now.
* The first two bytes are a (big endian) 16 bit offset into our buffer.
* The buffer timestamp refers to this offset.
@ -331,6 +340,14 @@ gst_dvdlpcmdec_chain_dvd (GstPad * pad, GstBuffer * buf)
* encoded.
*/
first_access = (data[0] << 8) | data[1];
if (first_access > size) {
GST_ELEMENT_WARNING (dvdlpcmdec, STREAM, DECODE,
("Invalid data found parsing LPCM packet"),
("LPCM packet contained invalid first access. Dropping"));
ret = GST_FLOW_OK;
goto done;
}
header = (data[2] << 16) | (data[3] << 8) | data[4];
/* see if we have a new header */