mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 11:41:09 +00:00
Code Issues 1 Projects Releases Wiki Activity

parsebin: fix critical when sorting pads

Browse source 
If the pad does not have a current caps, get_pad() returns the query
caps which can be ANY. In such case the caps does not have any structure
resulting in a critical warning when calling gst_caps_get_structure().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1254>
This commit is contained in:
Guillaume Desmottes 2021-10-26 15:12:16 +02:00 committed by GStreamer Marge Bot
parent e6f39394f5
commit 1d833eba60
1 changed files with 47 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

77
subprojects/gst-plugins-base/gst/playback/gstparsebin.c
View file

@ -3336,46 +3336,63 @@ static gint
sort_end_pads (GstParsePad * da, GstParsePad * db)
{
gint va, vb;
GstCaps *capsa, *capsb;
GstStructure *sa, *sb;
const gchar *namea, *nameb;
gchar *ida, *idb;
gint ret;
GstCaps *capsa, *capsb;
capsa = get_pad_caps (GST_PAD_CAST (da));
capsb = get_pad_caps (GST_PAD_CAST (db));
sa = gst_caps_get_structure ((const GstCaps *) capsa, 0);
sb = gst_caps_get_structure ((const GstCaps *) capsb, 0);
if (gst_caps_get_size (capsa) == 0 || gst_caps_get_size (capsb) == 0) {
if (gst_caps_is_any (capsa))
va = 6;
if (gst_caps_is_empty (capsa))
va = 7;
else
va = 0;
namea = gst_structure_get_name (sa);
nameb = gst_structure_get_name (sb);
if (gst_caps_is_any (capsb))
vb = 6;
if (gst_caps_is_empty (capsb))
vb = 7;
else
vb = 0;
} else {
GstStructure *sa, *sb;
if (g_strrstr (namea, "video/x-raw"))
va = 0;
else if (g_strrstr (namea, "video/"))
va = 1;
else if (g_strrstr (namea, "image/"))
va = 2;
else if (g_strrstr (namea, "audio/x-raw"))
va = 3;
else if (g_strrstr (namea, "audio/"))
va = 4;
else
va = 5;
sa = gst_caps_get_structure ((const GstCaps *) capsa, 0);
sb = gst_caps_get_structure ((const GstCaps *) capsb, 0);
if (g_strrstr (nameb, "video/x-raw"))
vb = 0;
else if (g_strrstr (nameb, "video/"))
vb = 1;
else if (g_strrstr (nameb, "image/"))
vb = 2;
else if (g_strrstr (nameb, "audio/x-raw"))
vb = 3;
else if (g_strrstr (nameb, "audio/"))
vb = 4;
else
vb = 5;
namea = gst_structure_get_name (sa);
nameb = gst_structure_get_name (sb);
if (g_strrstr (namea, "video/x-raw"))
va = 0;
else if (g_strrstr (namea, "video/"))
va = 1;
else if (g_strrstr (namea, "image/"))
va = 2;
else if (g_strrstr (namea, "audio/x-raw"))
va = 3;
else if (g_strrstr (namea, "audio/"))
va = 4;
else
va = 5;
if (g_strrstr (nameb, "video/x-raw"))
vb = 0;
else if (g_strrstr (nameb, "video/"))
vb = 1;
else if (g_strrstr (nameb, "image/"))
vb = 2;
else if (g_strrstr (nameb, "audio/x-raw"))
vb = 3;
else if (g_strrstr (nameb, "audio/"))
vb = 4;
else
vb = 5;
}
gst_caps_unref (capsa);
gst_caps_unref (capsb);