mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 11:32:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

videooverlaycomposition: ensure proper buffer copy

Browse source 
This is only temporary and could and should be modified to use
regular buffer copy once https://bugzilla.gnome.org/show_bug.cgi?id=679145
is resolved.
This commit is contained in:
Mark Nauwelaerts 2012-07-02 14:26:50 +02:00
parent d37422da2b
commit 1d413ace64
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
gst-libs/gst/video/video-overlay-composition.c
View file

@ -1015,6 +1015,22 @@ gst_video_overlay_rectangle_apply_global_alpha (GstVideoOverlayRectangle * rect,
rect->applied_global_alpha = global_alpha; rect->applied_global_alpha = global_alpha;
} }
/* need real independent buffer copy;
* see also https://bugzilla.gnome.org/show_bug.cgi?id=679145 */
static GstBuffer *
__gst_buffer_copy (GstBuffer * buf)
{
GstBuffer *newb;
GstMapInfo map;
newb = gst_buffer_new_and_alloc (gst_buffer_get_size (buf));
gst_buffer_map (buf, &map, GST_MAP_READ);
gst_buffer_fill (newb, 0, map.data, map.size);
gst_buffer_unmap (buf, &map);
return newb;
}
static GstBuffer * static GstBuffer *
gst_video_overlay_rectangle_get_pixels_argb_internal (GstVideoOverlayRectangle * gst_video_overlay_rectangle_get_pixels_argb_internal (GstVideoOverlayRectangle *
rectangle, guint * stride, GstVideoOverlayFormatFlags flags, rectangle, guint * stride, GstVideoOverlayFormatFlags flags,
@ -1096,7 +1112,7 @@ gst_video_overlay_rectangle_get_pixels_argb_internal (GstVideoOverlayRectangle *
} else { } else {
/* if we don't have to scale, we have to modify the alpha values, so we /* if we don't have to scale, we have to modify the alpha values, so we
* need to make a copy of the pixel memory (and we take ownership below) */ * need to make a copy of the pixel memory (and we take ownership below) */
buf = gst_buffer_copy (rectangle->pixels); buf = __gst_buffer_copy (rectangle->pixels);
} }
new_flags = rectangle->flags; new_flags = rectangle->flags;