mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 04:36:20 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtspconnection: Don't use argument for local storage

Browse source 
By re-using the uri argument for storing local data, we could end up in
a situation where we would free uri ... which would actually be the
string passed in argument.

Instead explicitely use a local variable. Fixes double-free issues.

CID #1212176
This commit is contained in:
Edward Hervey 2014-05-13 11:51:55 +02:00
parent e0cfd6e26b
commit 1ca576c240
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst-libs/gst/rtsp/gstrtspconnection.c
View file

@ -636,6 +636,7 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri)
GError *error = NULL; GError *error = NULL;
GSocketConnection *connection; GSocketConnection *connection;
GSocket *socket; GSocket *socket;
gchar *luri = NULL;
memset (&response, 0, sizeof (response)); memset (&response, 0, sizeof (response));
gst_rtsp_message_init (&response); gst_rtsp_message_init (&response);
@ -689,7 +690,7 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri)
} }
gst_rtsp_url_get_port (url, &url_port); gst_rtsp_url_get_port (url, &url_port);
uri = g_strdup_printf ("http://%s:%d%s%s%s", url->host, url_port, luri = g_strdup_printf ("http://%s:%d%s%s%s", url->host, url_port,
url->abspath, url->query ? "?" : "", url->query ? url->query : ""); url->abspath, url->query ? "?" : "", url->query ? url->query : "");
/* connect to the host/port */ /* connect to the host/port */
@ -698,7 +699,7 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri)
conn->proxy_host, conn->proxy_port, conn->cancellable, &error); conn->proxy_host, conn->proxy_port, conn->cancellable, &error);
} else { } else {
connection = g_socket_client_connect_to_uri (conn->client, connection = g_socket_client_connect_to_uri (conn->client,
uri, 0, conn->cancellable, &error); luri, 0, conn->cancellable, &error);
} }
if (connection == NULL) if (connection == NULL)
goto connect_failed; goto connect_failed;
@ -720,7 +721,7 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri)
conn->control_stream = NULL; conn->control_stream = NULL;
/* create the POST request for the write connection */ /* create the POST request for the write connection */
GST_RTSP_CHECK (gst_rtsp_message_new_request (&msg, GST_RTSP_POST, uri), GST_RTSP_CHECK (gst_rtsp_message_new_request (&msg, GST_RTSP_POST, luri),
no_message); no_message);
msg->type = GST_RTSP_MESSAGE_HTTP_REQUEST; msg->type = GST_RTSP_MESSAGE_HTTP_REQUEST;
@ -743,7 +744,7 @@ setup_tunneling (GstRTSPConnection * conn, GTimeVal * timeout, gchar * uri)
exit: exit:
gst_rtsp_message_unset (&response); gst_rtsp_message_unset (&response);
g_free (uri); g_free (luri);
return res; return res;