mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-06 07:28:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

omx: allow 0 feature

Browse source 
Previously the omx plugin was blacklisted if GST_OMX_CONFIG_DIR
points to an invalid path or if the gstomx.conf contains 0 valid
component.
Problem is that once the plugin is blacklisted, a rescan is not
triggered upon changes of the env var or the gstomx.conf file
despite being setup with gst_plugin_add_dependency.

This also makes it more consistent with other plugins that auto
generate features. For example gst-{ffmeg,libav}, gstreamer-vaapi,
v4l2 video dec.

To clarify the diff, the plugin_init func will return TRUE even if
g_key_file_get_groups returns 0 element and even if
g_key_file_load_from_dirs fails.

https://bugzilla.gnome.org/show_bug.cgi?id=782867
This commit is contained in:
Julien Isorce 2017-05-20 14:49:20 +01:00
parent 29ce1d9152
commit 1c8f069e42
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
omx/gstomx.c
View file

@ -2659,7 +2659,6 @@ _class_init (gpointer g_class, gpointer data)
static gboolean static gboolean
plugin_init (GstPlugin * plugin) plugin_init (GstPlugin * plugin)
{ {
gboolean ret = FALSE;
GError *err = NULL; GError *err = NULL;
gchar **config_dirs; gchar **config_dirs;
gchar **elements; gchar **elements;
@ -2807,7 +2806,7 @@ plugin_init (GstPlugin * plugin)
} }
subtype = g_type_register_static (type, type_name, &type_info, 0); subtype = g_type_register_static (type, type_name, &type_info, 0);
g_free (type_name); g_free (type_name);
ret |= gst_element_register (plugin, elements[i], rank, subtype); gst_element_register (plugin, elements[i], rank, subtype);
} }
g_strfreev (elements); g_strfreev (elements);
@ -2815,7 +2814,7 @@ done:
g_free (env_config_dir); g_free (env_config_dir);
g_free (config_dirs); g_free (config_dirs);
return ret; return TRUE;
} }
GST_PLUGIN_DEFINE (GST_VERSION_MAJOR, GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,