mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 04:01:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

camerabin2: encodebin might not have the requested pad

Browse source 
handle the case where encodebin doesn't have the pad
camerabin2 is requesting, either because of its current profile
or because of missing elements, making it fail to provide
the pad
This commit is contained in:
Thiago Santos 2011-04-28 14:37:22 -03:00
parent dfe815e048
commit 1c8e1722eb
1 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
gst/camerabin2/gstcamerabin2.c
View file

@ -901,10 +901,16 @@ gst_camera_bin_link_encodebin (GstCameraBin * camera, GstElement * element,
GstPad *sinkpad = NULL;
srcpad = gst_element_get_static_pad (element, "src");
g_assert (srcpad != NULL);
sinkpad = encodebin_find_pad (camera, padtype);
g_assert (srcpad != NULL);
g_assert (sinkpad != NULL);
/* there may be no available sink pad for encodebin in some situations:
* e.g. missing elements or incompatible padtype */
if (sinkpad == NULL) {
gst_object_unref (srcpad);
return GST_PAD_LINK_REFUSED;
}
ret = gst_pad_link (srcpad, sinkpad);
gst_object_unref (sinkpad);
@ -1037,8 +1043,10 @@ gst_camera_bin_create_elements (GstCameraBin * camera)
if (camera->profile_switch) {
GST_DEBUG_OBJECT (camera, "Switching encodebin's profile");
g_object_set (camera->encodebin, "profile", camera->video_profile, NULL);
gst_camera_bin_link_encodebin (camera, camera->videobin_capsfilter,
VIDEO_PAD);
if (GST_PAD_LINK_FAILED (gst_camera_bin_link_encodebin (camera,
camera->videobin_capsfilter, VIDEO_PAD))) {
goto fail;
}
camera->profile_switch = FALSE;
/* used to trigger relinking further down */
@ -1147,11 +1155,18 @@ gst_camera_bin_create_elements (GstCameraBin * camera)
}
if ((profile_switched && has_audio) || new_audio_src) {
gst_camera_bin_link_encodebin (camera, camera->audio_convert, AUDIO_PAD);
if (GST_PAD_LINK_FAILED (gst_camera_bin_link_encodebin (camera,
camera->audio_convert, AUDIO_PAD))) {
goto fail;
}
}
camera->elements_created = TRUE;
return TRUE;
fail:
/* FIXME properly clean up */
return FALSE;
}
static GstStateChangeReturn