mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-25 01:10:44 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstmeta: intern registered impl string

Browse source 
Subsequent lookups in the hashtable are probably better done
on memory we're confident is allocated to us :)

It was easy to trigger invalid reads by calling gst_meta_register
with dynamically allocated memory, freeing that memory, then
calling gst_meta_get_info()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/647>
This commit is contained in:
Mathieu Duponchelle 2020-09-16 02:16:52 +02:00 committed by GStreamer Merge Bot
parent eed0e22020
commit 1baa2ba9f0
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst/gstmeta.c
View file

@ -198,7 +198,8 @@ gst_meta_register (GType api, const gchar * impl, gsize size,
g_type_name (api), size);
g_rw_lock_writer_lock (&lock);
g_hash_table_insert (metainfo, (gpointer) impl, (gpointer) info);
g_hash_table_insert (metainfo, (gpointer) g_intern_string (impl),
(gpointer) info);
g_rw_lock_writer_unlock (&lock);
return info;