mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

interlace: Drop framerate from query caps of sinkpad

Browse source 
Query caps should return caps which represent the element can accept,
not resulting format.

Fixing negotiation error with
gst-launch-1.0 videotestsrc ! video/x-raw,framerate=25/1 ! interlace field-pattern=0 ! fakesink

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2282>
This commit is contained in:
Seungha Yang 2021-05-25 19:47:28 +09:00 committed by GStreamer Marge Bot
parent da33921f8d
commit 1ac30ad53f
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst/interlace/gstinterlace.c
View file

@ -980,18 +980,25 @@ gst_interlace_getcaps (GstPad * pad, GstInterlace * interlace, GstCaps * filter)
icaps = gst_caps_merge (icaps, alternate); icaps = gst_caps_merge (icaps, alternate);
} }
if (pattern == GST_INTERLACE_PATTERN_1_1) { /* Drop framerate for sinkpad */
icaps = if (pad == interlace->sinkpad) {
gst_interlace_caps_double_framerate (icaps, (pad == interlace->srcpad),
FALSE);
} else if (pattern != GST_INTERLACE_PATTERN_2_2) {
GST_FIXME_OBJECT (interlace,
"Add calculations for telecine framerate conversions");
for (i = 0; i < gst_caps_get_size (icaps); ++i) { for (i = 0; i < gst_caps_get_size (icaps); ++i) {
GstStructure *s = gst_caps_get_structure (icaps, i); GstStructure *s = gst_caps_get_structure (icaps, i);
gst_structure_remove_field (s, "framerate"); gst_structure_remove_field (s, "framerate");
} }
} else {
if (pattern == GST_INTERLACE_PATTERN_1_1) {
icaps = gst_interlace_caps_double_framerate (icaps, TRUE, FALSE);
} else if (pattern != GST_INTERLACE_PATTERN_2_2) {
GST_FIXME_OBJECT (interlace,
"Add calculations for telecine framerate conversions");
for (i = 0; i < gst_caps_get_size (icaps); ++i) {
GstStructure *s = gst_caps_get_structure (icaps, i);
gst_structure_remove_field (s, "framerate");
}
}
} }
if (clean_filter) if (clean_filter)