mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-09-27 06:20:12 +00:00
Code Issues 1 Projects Releases Wiki Activity

paramspec: Fix array validation logic

Browse source 
A paramspec validation should modify the content to match what the spec
requires and return TURE if a modification happened. This previous
implementation would only fix the first element of the array and return.
It was also return TRUE for empty array, while no modification was
needed.

https://bugzilla.gnome.org/show_bug.cgi?id=780111
This commit is contained in:
Nicolas Dufresne 2017-03-15 17:31:39 -04:00
parent 3b9ff1245b
commit 1a65d5b252
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/gstparamspecs.c
View file

@ -233,6 +233,7 @@ static gboolean
_gst_param_array_validate (GParamSpec * pspec, GValue * value)
{
GstParamSpecArray *aspec = GST_PARAM_SPEC_ARRAY_LIST (pspec);
gboolean ret = FALSE;
/* ensure array values validity against a present element spec */
if (aspec->element_spec) {
@ -249,15 +250,16 @@ _gst_param_array_validate (GParamSpec * pspec, GValue * value)
g_value_unset (element);
g_value_init (element, G_PARAM_SPEC_VALUE_TYPE (element_spec));
g_param_value_set_default (element_spec, element);
return FALSE;
ret = TRUE;
}
/* validate array value against element_spec */
if (!g_param_value_validate (element_spec, element))
return FALSE;
if (g_param_value_validate (element_spec, element))
ret = TRUE;
}
}
return TRUE;
return ret;
}
static gint