mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 00:32:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

camerabin: handle EOS on the pipeline

Browse source 
Make camerabin handle EOS to the pipeline to allow standard pipeline
close where an EOS is sent to the whole pipeline before setting it to NULL.
This commit is contained in:
Thiago Santos 2014-07-23 13:37:05 -03:00
parent 29dd215649
commit 19d5be4c3a
2 changed files with 19 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
gst/camerabin2/gstcamerabin2.c
View file

@ -1101,17 +1101,24 @@ gst_camera_bin_handle_message (GstBin * bin, GstMessage * message)
g_mutex_lock (&camerabin->video_capture_mutex);
GST_DEBUG_OBJECT (bin, "EOS from video branch");
g_assert (camerabin->video_state == GST_CAMERA_BIN_VIDEO_FINISHING);
if (!g_thread_try_new ("reset-element-thread",
gst_camera_bin_video_reset_elements, gst_object_ref (camerabin),
NULL)) {
GST_WARNING_OBJECT (camerabin,
"Failed to create thread to "
"reset video elements' state, video recordings may not work "
"anymore");
gst_object_unref (camerabin);
camerabin->video_state = GST_CAMERA_BIN_VIDEO_IDLE;
if (camerabin->video_state == GST_CAMERA_BIN_VIDEO_FINISHING) {
if (!g_thread_try_new ("reset-element-thread",
gst_camera_bin_video_reset_elements,
gst_object_ref (camerabin), NULL)) {
GST_WARNING_OBJECT (camerabin,
"Failed to create thread to "
"reset video elements' state, video recordings may not work "
"anymore");
gst_object_unref (camerabin);
camerabin->video_state = GST_CAMERA_BIN_VIDEO_IDLE;
}
} else if (camerabin->video_state == GST_CAMERA_BIN_VIDEO_IDLE) {
GST_DEBUG_OBJECT (camerabin, "Received EOS from video branch but "
"video recording is idle, ignoring");
} else {
GST_WARNING_OBJECT (camerabin, "Received EOS from video branch but "
"video is recording and stop-capture wasn't requested");
g_assert_not_reached ();
}
g_mutex_unlock (&camerabin->video_capture_mutex);
@ -1760,7 +1767,7 @@ gst_camera_bin_create_elements (GstCameraBin2 * camera)
G_CALLBACK (gst_camera_bin_src_notify_readyforcapture), camera);
if (!gst_element_link_pads (camera->src, "vfsrc",
camera->viewfinderbin_queue, "sink")) {
camera->viewfinderbin_queue, "sink")) {
GST_ERROR_OBJECT (camera,
"Failed to link camera source's vfsrc pad to viewfinder queue");
goto fail;

4
gst/camerabin2/gstwrappercamerabinsrc.c
View file

@ -312,10 +312,6 @@ gst_wrapper_camera_src_src_event_probe (GstPad * pad, GstPadProbeInfo * info,
GstEvent *evt = GST_EVENT (info->data);
switch (GST_EVENT_TYPE (evt)) {
case GST_EVENT_EOS:
/* drop */
ret = GST_PAD_PROBE_DROP;
break;
case GST_EVENT_SEGMENT:
if (self->drop_newseg) {
ret = GST_PAD_PROBE_DROP;