mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-12 02:15:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

videosink: Implement more complete BaseSink::get_times() based on the framerate

Browse source 
This will only make use of the framerate if the subclass is chaining up
BaseSink::set_caps(). Otherwise it will have the same behaviour as the
basesink default.

Doing so is useful if video buffers don't contain a duration to
calculate a default duration, and various video sinks already implement
a custom version of this.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/986>
This commit is contained in:
Sebastian Dröge 2020-12-26 14:16:34 +02:00 committed by GStreamer Merge Bot
parent 1f06cf60e7
commit 198434e71a
1 changed files with 71 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
gst-libs/gst/video/gstvideosink.c
View file

@ -36,6 +36,7 @@
#endif
#include "gstvideosink.h"
#include "video-info.h"
enum
{
@ -46,6 +47,7 @@ enum
struct _GstVideoSinkPrivate
{
GstVideoInfo info;
gboolean show_preroll_frame; /* ATOMIC */
};
@ -78,10 +80,15 @@ static void gst_video_sink_set_property (GObject * object, guint prop_id,
static void gst_video_sink_get_property (GObject * object, guint prop_id,
GValue * value, GParamSpec * pspec);
static GstStateChangeReturn gst_video_sink_change_state (GstElement * element,
GstStateChange transition);
static GstFlowReturn gst_video_sink_show_preroll_frame (GstBaseSink * bsink,
GstBuffer * buf);
static GstFlowReturn gst_video_sink_show_frame (GstBaseSink * bsink,
GstBuffer * buf);
static gboolean gst_video_sink_set_caps (GstBaseSink * bsink, GstCaps * caps);
static void gst_video_sink_get_times (GstBaseSink * bsink, GstBuffer * buffer,
GstClockTime * start, GstClockTime * end);
/**
* gst_video_sink_center_rect:
@ -153,6 +160,7 @@ gst_video_sink_init (GstVideoSink * videosink)
static void
gst_video_sink_class_init (GstVideoSinkClass * klass)
{
GstElementClass *element_class = (GstElementClass *) klass;
GstBaseSinkClass *basesink_class = (GstBaseSinkClass *) klass;
GObjectClass *gobject_class = (GObjectClass *) klass;
@ -173,9 +181,72 @@ gst_video_sink_class_init (GstVideoSinkClass * klass)
DEFAULT_SHOW_PREROLL_FRAME,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT | G_PARAM_STATIC_STRINGS));
element_class->change_state = GST_DEBUG_FUNCPTR (gst_video_sink_change_state);
basesink_class->render = GST_DEBUG_FUNCPTR (gst_video_sink_show_frame);
basesink_class->preroll =
GST_DEBUG_FUNCPTR (gst_video_sink_show_preroll_frame);
basesink_class->set_caps = GST_DEBUG_FUNCPTR (gst_video_sink_set_caps);
basesink_class->get_times = GST_DEBUG_FUNCPTR (gst_video_sink_get_times);
}
static GstStateChangeReturn
gst_video_sink_change_state (GstElement * element, GstStateChange transition)
{
GstVideoSink *vsink;
vsink = GST_VIDEO_SINK_CAST (element);
switch (transition) {
case GST_STATE_CHANGE_READY_TO_PAUSED:
memset (&vsink->priv->info, 0, sizeof (vsink->priv->info));
break;
default:
break;
}
return GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);
}
static gboolean
gst_video_sink_set_caps (GstBaseSink * bsink, GstCaps * caps)
{
GstVideoSink *vsink;
GstVideoInfo info;
vsink = GST_VIDEO_SINK_CAST (bsink);
if (!gst_video_info_from_caps (&info, caps)) {
GST_ERROR_OBJECT (bsink, "Failed to parse caps %" GST_PTR_FORMAT, caps);
return FALSE;
}
GST_DEBUG_OBJECT (bsink, "Setting caps %" GST_PTR_FORMAT, caps);
vsink->priv->info = info;
return TRUE;
}
static void
gst_video_sink_get_times (GstBaseSink * bsink, GstBuffer * buffer,
GstClockTime * start, GstClockTime * end)
{
GstVideoSink *vsink;
GstClockTime timestamp;
vsink = GST_VIDEO_SINK_CAST (bsink);
timestamp = GST_BUFFER_DTS_OR_PTS (buffer);
if (GST_CLOCK_TIME_IS_VALID (timestamp)) {
*start = timestamp;
if (GST_BUFFER_DURATION_IS_VALID (buffer)) {
*end = timestamp + GST_BUFFER_DURATION (buffer);
} else if (vsink->priv->info.fps_n > 0) {
*end = timestamp +
gst_util_uint64_scale_int (GST_SECOND, vsink->priv->info.fps_d,
vsink->priv->info.fps_n);
}
}
}
static GstFlowReturn