mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-23 15:48:23 +00:00
Code Issues 1 Projects Releases Wiki Activity

dvbsrc: add basic checks on ISDB-T parameters

Browse source 
Also add a routine for checking wrong delsys/modulation
combinations right before tuning (only implemented for
ISDB-T for now).
This commit is contained in:
Reynaldo H. Verdejo Pinochet 2014-08-29 17:16:09 -04:00
parent fd64a75926
commit 17beaed35f
1 changed files with 54 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
sys/dvb/gstdvbsrc.c
View file

@ -525,6 +525,7 @@ static gboolean gst_dvbsrc_tune_fe (GstDvbSrc * object);
static void gst_dvbsrc_set_pes_filters (GstDvbSrc * object); static void gst_dvbsrc_set_pes_filters (GstDvbSrc * object);
static void gst_dvbsrc_unset_pes_filters (GstDvbSrc * object); static void gst_dvbsrc_unset_pes_filters (GstDvbSrc * object);
static gboolean gst_dvbsrc_is_valid_modulation (guint delsys, guint mod);
/** /**
* This loop should be safe enough considering: * This loop should be safe enough considering:
@ -1964,6 +1965,24 @@ gst_dvbsrc_is_seekable (GstBaseSrc * bsrc)
return FALSE; return FALSE;
} }
static gboolean
gst_dvbsrc_is_valid_modulation (guint delsys, guint mod)
{
/* FIXME: check valid modulations for other broadcast standards */
switch (mod) {
case SYS_ISDBT:
if (mod == QAM_AUTO || mod == QPSK || mod == QAM_16 ||
mod == QAM_64 || mod == DQPSK)
return TRUE;
break;
default:
GST_FIXME ("No delsys/modulation sanity checks implemented for this "
"delivery system");
return TRUE;
}
return FALSE;
}
static gboolean static gboolean
gst_dvbsrc_get_size (GstBaseSrc * src, guint64 * size) gst_dvbsrc_get_size (GstBaseSrc * src, guint64 * size)
{ {
@ -2243,6 +2262,12 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props)
/* first 3 entries are reserved */ /* first 3 entries are reserved */
n = 3; n = 3;
/**
* We are not dropping out but issuing a warning in case of wrong
* parameter combinations as this behavior should be mandated by the
* driver. Worst case scenario it will just fail at tuning.
*/
switch (object->delsys) { switch (object->delsys) {
case SYS_DVBS: case SYS_DVBS:
case SYS_DVBS2: case SYS_DVBS2:
@ -2336,10 +2361,30 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props)
set_prop (props->props, &n, DTV_MODULATION, object->modulation); set_prop (props->props, &n, DTV_MODULATION, object->modulation);
break; break;
case SYS_ISDBT: case SYS_ISDBT:
/* FIXME: This works but further parameter sanity checking
* can be done for some property combinatios. This is still if (object->isdbt_partial_reception == 1 &&
* safe anyway, as the current worst case scenario is just object->isdbt_layera_segment_count != 1) {
* a fail at tuning/locking */ GST_WARNING_OBJECT (object, "Wrong ISDB-T parameter combination: "
"partial reception is set but layer A segment count is not 1");
}
if (!object->isdbt_sound_broadcasting) {
GST_INFO_OBJECT (object, "ISDB-T sound broadcasting is not set. "
"Driver will likely ignore values set for isdbt-sb-subchannel-id, "
"isdbt-sb-segment-idx and isdbt-sb-segment-count");
}
if (object->isdbt_layerc_modulation == DQPSK &&
object->isdbt_layerb_modulation != DQPSK) {
GST_WARNING_OBJECT (object, "Wrong ISDB-T parameter combination: "
"layer C modulation is DQPSK but layer B modulation is different");
}
if (object->bandwidth != 6000000) {
GST_WARNING_OBJECT (object, "Wrong ISDB-T parameter value: bandwidth "
"is %d but only 6 MHz is allowed", object->bandwidth);
}
GST_INFO_OBJECT (object, "Tuning ISDB-T to %d", freq); GST_INFO_OBJECT (object, "Tuning ISDB-T to %d", freq);
set_prop (props->props, &n, DTV_BANDWIDTH_HZ, object->bandwidth); set_prop (props->props, &n, DTV_BANDWIDTH_HZ, object->bandwidth);
set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval); set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval);
@ -2387,6 +2432,11 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props)
return FALSE; return FALSE;
} }
if (!gst_dvbsrc_is_valid_modulation (object->delsys, object->modulation)) {
GST_WARNING_OBJECT (object,
"Attempting an invalid modulation/delsys combination");
}
set_prop (props->props, &n, DTV_TUNE, 0); set_prop (props->props, &n, DTV_TUNE, 0);
props->num = n; props->num = n;
/* set first three entries */ /* set first three entries */