mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-03 09:12:19 +00:00
Code Issues 1 Projects Releases Wiki Activity

cutter: Fix buffer leak

Browse source 
Buffer is added to the internal cache, and pushed only when accumulated
buffer duration crosses 200 ms. So when the chain ends, the buffer accumulated
is not freed. Freeing the cache when the state changes from PAUSED to READY.

https://bugzilla.gnome.org/show_bug.cgi?id=754212
This commit is contained in:
Vineeth TM 2015-10-05 13:10:56 +09:00 committed by Sebastian Dröge
parent 58073eaa7a
commit 15b08e0bd5
1 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
gst/cutter/gstcutter.c
View file

@ -97,6 +97,9 @@ enum
#define gst_cutter_parent_class parent_class
G_DEFINE_TYPE (GstCutter, gst_cutter, GST_TYPE_ELEMENT);
static GstStateChangeReturn
gst_cutter_change_state (GstElement * element, GstStateChange transition);
static void gst_cutter_set_property (GObject * object, guint prop_id,
const GValue * value, GParamSpec * pspec);
static void gst_cutter_get_property (GObject * object, guint prop_id,
@ -152,6 +155,7 @@ gst_cutter_class_init (GstCutterClass * klass)
"Filter/Editor/Audio",
"Audio Cutter to split audio into non-silent bits",
"Thomas Vander Stichele <thomas at apestaart dot org>");
element_class->change_state = gst_cutter_change_state;
}
static void
@ -236,6 +240,25 @@ gst_cutter_setcaps (GstCutter * filter, GstCaps * caps)
return gst_pad_set_caps (filter->srcpad, caps);
}
static GstStateChangeReturn
gst_cutter_change_state (GstElement * element, GstStateChange transition)
{
GstStateChangeReturn ret;
GstCutter *filter = GST_CUTTER (element);
ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);
switch (transition) {
case GST_STATE_CHANGE_PAUSED_TO_READY:
g_list_free_full (filter->pre_buffer, (GDestroyNotify) gst_buffer_unref);
filter->pre_buffer = NULL;
break;
default:
break;
}
return ret;
}
static gboolean
gst_cutter_event (GstPad * pad, GstObject * parent, GstEvent * event)
{