mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-10 17:35:59 +00:00
Code Issues 1 Projects Releases Wiki Activity

libs/gst/base/gstcollectpads.c: Collectpads now holds a reference to the GstPad that was added. Indeed we don't want ...

Browse source 
Original commit message from CVS:
2006-02-05  Julien MOUTTE  <julien@moutte.net>

* libs/gst/base/gstcollectpads.c: (gst_collect_pads_finalize),
(gst_collect_pads_add_pad), (gst_collect_pads_remove_pad),
(gst_collect_pads_start), (gst_collect_pads_stop),
(gst_collect_pads_event): Collectpads now holds a reference
to the GstPad that was added. Indeed we don't want to look
at pads that might just go away with no warning...
This commit is contained in:
Julien Moutte 2006-02-05 18:13:28 +00:00
parent eafd3ff391
commit 14de34d6ec
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
2006-02-05 Julien MOUTTE <julien@moutte.net>
* libs/gst/base/gstcollectpads.c: (gst_collect_pads_finalize),
(gst_collect_pads_add_pad), (gst_collect_pads_remove_pad),
(gst_collect_pads_start), (gst_collect_pads_stop),
(gst_collect_pads_event): Collectpads now holds a reference
to the GstPad that was added. Indeed we don't want to look
at pads that might just go away with no warning...
2006-02-05 Julien MOUTTE <julien@moutte.net>
* libs/gst/base/gstcollectpads.c: (gst_collect_pads_add_pad),

16
libs/gst/base/gstcollectpads.c
View file

@ -112,10 +112,23 @@ gst_collect_pads_init (GstCollectPads * pads, GstCollectPadsClass * g_class)
static void
gst_collect_pads_finalize (GObject * object)
{
GSList *collected;
GstCollectPads *pads = GST_COLLECT_PADS (object);
gst_collect_pads_stop (pads);
g_cond_free (pads->cond);
/* Remove pads */
for (collected = pads->data; collected; collected = g_slist_next (collected)) {
GstCollectData *pdata = (GstCollectData *) collected->data;
if (pdata->pad) {
gst_object_unref (pdata->pad);
}
}
/* Free pads list */
g_slist_free (pads->data);
/* FIXME, free data */
G_OBJECT_CLASS (parent_class)->finalize (object);
@ -194,7 +207,7 @@ gst_collect_pads_add_pad (GstCollectPads * pads, GstPad * pad, guint size)
data = g_malloc0 (size);
data->collect = pads;
data->pad = pad;
data->pad = gst_object_ref (pad);
data->buffer = NULL;
gst_segment_init (&data->segment, GST_FORMAT_UNDEFINED);
data->abidata.ABI.flushing = FALSE;
@ -246,6 +259,7 @@ gst_collect_pads_remove_pad (GstCollectPads * pads, GstPad * pad)
if (list) {
g_free (list->data);
pads->data = g_slist_delete_link (pads->data, list);
gst_object_unref (pad);
}
pads->numpads--;
/* FIXME : if the pad has data queued we should decrease the number of