mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-25 11:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

pad-monitor: fix expected setcaps fields comparison

Browse source 
Use the correct structure when getting the GValues and print different
messages for missing and different fields on the setcaps caps
This commit is contained in:
Thiago Santos 2013-07-22 20:09:35 -03:00
parent 363de0e555
commit 11cc2e6b3b
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
validate/gst/qa/gst-qa-pad-monitor.c
View file

@ -1247,15 +1247,27 @@ gst_qa_pad_monitor_setcaps_func (GstPad * pad, GstCaps * caps)
structure = gst_caps_get_structure (caps, 0); structure = gst_caps_get_structure (caps, 0);
if (gst_structure_n_fields (pad_monitor->pending_setcaps_fields)) { if (gst_structure_n_fields (pad_monitor->pending_setcaps_fields)) {
gint i; gint i;
for (i = 0; i < gst_structure_n_fields (structure); i++) { for (i = 0;
const gchar *name = gst_structure_nth_field_name (structure, i); i < gst_structure_n_fields (pad_monitor->pending_setcaps_fields);
i++) {
const gchar *name =
gst_structure_nth_field_name (pad_monitor->pending_setcaps_fields,
i);
const GValue *v = gst_structure_get_value (structure, name); const GValue *v = gst_structure_get_value (structure, name);
const GValue *otherv = gst_structure_get_value (structure, name); const GValue *otherv =
gst_structure_get_value (pad_monitor->pending_setcaps_fields, name);
if (!gst_value_compare (v, otherv) != GST_VALUE_EQUAL) { if (v == NULL) {
GST_QA_MONITOR_REPORT_WARNING (pad_monitor, FALSE, CAPS_NEGOTIATION, GST_QA_MONITOR_REPORT_WARNING (pad_monitor, FALSE, CAPS_NEGOTIATION,
MISSING_FIELD, MISSING_FIELD,
"Field %s is missing from setcaps %" GST_PTR_FORMAT, name, caps); "Field %s is missing from setcaps caps '%" GST_PTR_FORMAT "'",
name, caps);
} else if (gst_value_compare (v, otherv) != GST_VALUE_EQUAL) {
GST_QA_MONITOR_REPORT_WARNING (pad_monitor, FALSE, CAPS_NEGOTIATION,
MISSING_FIELD,
"Field %s from setcaps caps '%" GST_PTR_FORMAT "' is different "
"from expected value in caps '%" GST_PTR_FORMAT "'", name, caps,
pad_monitor->pending_setcaps_fields);
} }
} }
} }