mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-10 08:35:58 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "playbin2: Don't put "raw" subtitle types in the raw caps for decodebin2"

Browse source 
This reverts commit 9d7538247f.

If the DVD subpicture caps are not part of the raw caps, uridecodebin
doesn't qualify resindvdbin as raw source and plugs decodebins, which
causes broken DVD playback because of bugs elsewhere.

This change was originally added to only expose supported, raw subtitles,
e.g. if the subtitle sink did not support DVD subpictures but a converter
to some supported format exists. It's not very important right now because
we have nothing (that is autoplugged) to convert from plaintext/pango-markup
or DVD subpictures to something else.

Fixes bug #623583.
This commit is contained in:
Sebastian Dröge 2010-07-06 09:47:45 +02:00
parent 6e9deae749
commit 115e503bdf
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gst/playback/gstplaybin2.c
View file

@ -560,10 +560,6 @@ static GstElementClass *parent_class;
static guint gst_play_bin_signals[LAST_SIGNAL] = { 0 };
static GstStaticCaps av_raw_caps = GST_STATIC_CAPS ("audio/x-raw-int; "
"audio/x-raw-float; "
"video/x-raw-yuv; " "video/x-raw-rgb; " "video/x-raw-gray;");
#define REMOVE_SIGNAL(obj,id) \
if (id) { \
g_signal_handler_disconnect (obj, id); \
@ -3177,8 +3173,6 @@ activate_group (GstPlayBin * playbin, GstSourceGroup * group, GstState target)
uridecodebin = gst_element_factory_make ("uridecodebin", NULL);
if (!uridecodebin)
goto no_decodebin;
g_object_set (uridecodebin, "caps", gst_static_caps_get (&av_raw_caps),
NULL);
gst_bin_add (GST_BIN_CAST (playbin), uridecodebin);
group->uridecodebin = gst_object_ref (uridecodebin);
}
@ -3250,8 +3244,7 @@ activate_group (GstPlayBin * playbin, GstSourceGroup * group, GstState target)
suburidecodebin = gst_element_factory_make ("uridecodebin", NULL);
if (!suburidecodebin)
goto no_decodebin;
g_object_set (uridecodebin, "caps", gst_static_caps_get (&av_raw_caps),
NULL);
gst_bin_add (GST_BIN_CAST (playbin), suburidecodebin);
group->suburidecodebin = gst_object_ref (suburidecodebin);
}