mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-06 10:42:22 +00:00
Code Issues 1 Projects Releases Wiki Activity

glbasefilter: Need to check the display before lock it.

Browse source 
In find_gl_context_unlocked(), the display of filter may be NULL
and can cause crash if we directly access and lock it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/922>
This commit is contained in:
He Junyan 2020-11-06 15:36:01 +08:00
parent 089a1f56b0
commit 1146a7e3a0
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst-libs/gst/gl/gstglbasefilter.c
View file

@ -541,6 +541,11 @@ gst_gl_base_filter_find_gl_context_unlocked (GstGLBaseFilter * filter)
_find_local_gl_context_unlocked (filter);
if (!filter->display) {
GST_WARNING_OBJECT (filter, "filter has NULL display.");
return FALSE;
}
if (!filter->context) {
GST_OBJECT_LOCK (filter->display);
do {