mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 17:50:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

subparse: don't deref a potentially NULL variable

Browse source 
If the html SAMI data is malformed, then retrieving the attribute name
may fail.  We then cannot retrieve the attribute value.

Fixes: https://oss-fuzz.com/testcase-detail/4700130671984640
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2325>
This commit is contained in:
Matthew Waters 2022-04-28 15:32:27 +10:00 committed by GStreamer Marge Bot
parent d953d4de90
commit 105b0772c1
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subprojects/gst-plugins-base/gst/subparse/samiparse.c
View file

@ -494,6 +494,10 @@ html_context_handle_element (HtmlContext * ctxt,
gchar *attr_name = NULL, *attr_value = NULL; gchar *attr_name = NULL, *attr_value = NULL;
gsize length; gsize length;
next = string_token (next + 1, "=", &attr_name); next = string_token (next + 1, "=", &attr_name);
if (!next) {
g_free (attr_name);
break;
}
next = string_token (next + 1, " ", &attr_value); next = string_token (next + 1, " ", &attr_value);
/* strip " or ' from attribute value */ /* strip " or ' from attribute value */